Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2307003002: Move collectGarbage* methods to ThreadState (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebHeap.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2691 matching lines...) Expand 10 before | Expand all | Expand 10 after
2702 registry.didAddEventHandler(*div, EventHandlerRegistry::ScrollEvent); 2702 registry.didAddEventHandler(*div, EventHandlerRegistry::ScrollEvent);
2703 EXPECT_TRUE(registry.hasEventHandlers(EventHandlerRegistry::ScrollEvent)); 2703 EXPECT_TRUE(registry.hasEventHandlers(EventHandlerRegistry::ScrollEvent));
2704 2704
2705 TrackExceptionState exceptionState; 2705 TrackExceptionState exceptionState;
2706 div->remove(exceptionState); 2706 div->remove(exceptionState);
2707 2707
2708 // For oilpan we have to force a GC to ensure the event handlers have been r emoved when 2708 // For oilpan we have to force a GC to ensure the event handlers have been r emoved when
2709 // checking below. We do a precise GC (collectAllGarbage does not scan the s tack) 2709 // checking below. We do a precise GC (collectAllGarbage does not scan the s tack)
2710 // to ensure the div element dies. This is also why the Document is in a Per sistent 2710 // to ensure the div element dies. This is also why the Document is in a Per sistent
2711 // since we want that to stay around. 2711 // since we want that to stay around.
2712 ThreadHeap::collectAllGarbage(); 2712 ThreadState::current()-> collectAllGarbage();
2713 2713
2714 EXPECT_FALSE(registry.hasEventHandlers(EventHandlerRegistry::ScrollEvent)); 2714 EXPECT_FALSE(registry.hasEventHandlers(EventHandlerRegistry::ScrollEvent));
2715 } 2715 }
2716 2716
2717 class NonUserInputTextUpdateWebWidgetClient: public FrameTestHelpers::TestWebWid getClient { 2717 class NonUserInputTextUpdateWebWidgetClient: public FrameTestHelpers::TestWebWid getClient {
2718 public: 2718 public:
2719 NonUserInputTextUpdateWebWidgetClient() : m_textIsUpdated(false) { } 2719 NonUserInputTextUpdateWebWidgetClient() : m_textIsUpdated(false) { }
2720 2720
2721 // WebWidgetClient methods 2721 // WebWidgetClient methods
2722 void didUpdateTextOfFocusedElementByNonUserInput() override 2722 void didUpdateTextOfFocusedElementByNonUserInput() override
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
3364 EXPECT_TRUE(webView->page()->defersLoading()); 3364 EXPECT_TRUE(webView->page()->defersLoading());
3365 } 3365 }
3366 3366
3367 EXPECT_TRUE(webView->page()->defersLoading()); 3367 EXPECT_TRUE(webView->page()->defersLoading());
3368 } 3368 }
3369 3369
3370 EXPECT_FALSE(webView->page()->defersLoading()); 3370 EXPECT_FALSE(webView->page()->defersLoading());
3371 } 3371 }
3372 3372
3373 } // namespace blink 3373 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebHeap.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698