Issue 23069004: Check WebSocket close code sent on unload

Issue 23069004: Check WebSocket close code sent on unload (Closed)

Created:
7 years, 3 months ago by vivekg_samsung

Modified:
7 years, 3 months ago

Reviewers:
tyoshino (SeeGerritForStatus), vivekg__

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Check WebSocket close code sent on unload CL http://crrev.com/23201008 introduced sending the close code to the server on page navigation or page close with active WebSocket. This CL modifies the test cases to verify the close code sent by the server is 1001. BUG=276107 R=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156705

Patch Set 1 #

Patch Set 2 : Using python dictionary object to send JSON object back! #

Total comments: 1

Patch Set 3 : Patch for landing! #

Patch Set 4 : Updating the code comments for landing #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -14 lines)			Patch
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location.html	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-unload.html	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py	View	1 2 3	2 chunks	+10 lines, -8 lines	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/send-after-close-on-unload.html	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

lgtm https://codereview.chromium.org/23069004/diff/5001/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py File LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py (right): https://codereview.chromium.org/23069004/diff/5001/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py#newcode46 LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py:46: messageData = {} How about naming this "dataToBroadcast"?

7 years, 3 months ago (2013-08-26 08:49:14 UTC) #3

vivekg__

Thank you tyoshino for the review. I have modified the name!

7 years, 3 months ago (2013-08-26 08:56:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23069004/9001

7 years, 3 months ago (2013-08-26 09:09:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23069004/21001

7 years, 3 months ago (2013-08-26 09:23:05 UTC) #6

Message was sent while issue was closed.

Change committed as 156705

Expand Messages | Collapse Messages