LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html - Issue 23069004: Check WebSocket close code sent on unload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html

Issue 23069004: Check WebSocket close code sent on unload (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating the code comments for landing Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-expected.txt ('k') | LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html

diff --git a/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html b/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html

index 55a4d55583fd5571121b9be622bad6f9765db98b..9c338973d0b4a9b42876ee60871636372d8e4d35 100644

--- a/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html

+++ b/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html

@@ -13,6 +13,7 @@ window.jsTestIsAsync = true;

var frameDiv;

var closedSocket;

+var closeCode;

document.childWebSocket = null;

var ws = new WebSocket("ws://127.0.0.1:8880/websocket/tests/hybi/close-on-unload");

@@ -26,12 +27,15 @@ ws.onopen = function()

};

ws.onmessage = function(evt)

{

- closedSocket = evt.data;

+ var messageData = JSON.parse(evt.data);

+ closedSocket = messageData.message;

+ closeCode = messageData.closeCode;

ws.close();

};

ws.onclose = function()

{

shouldBe("closedSocket", '"socket1"');

+ shouldBe("closeCode", '"1001"');

shouldBe("document.childWebSocket.readyState", "3");

finishJSTest();

};