Issue 23069003: bench_util: allow optional whitespace in CSV format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23069003: bench_util: allow optional whitespace in CSV format (Closed)

Created:
7 years, 4 months ago by epoger

Modified:
7 years, 4 months ago

Reviewers:
benchen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

bench_util: allow optional whitespace in CSV format BUG=https://code.google.com/p/skia/issues/detail?id=1500 R=bensong@google.com Committed: https://code.google.com/p/skia/source/detail?r=10692

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bench/bench_util.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

https://codereview.chromium.org/23069003/diff/1/bench/bench_util.py File bench/bench_util.py (right): https://codereview.chromium.org/23069003/diff/1/bench/bench_util.py#newcode20 bench/bench_util.py:20: TIME_RE = '(?:(\w*)msecs = )?\s*((?:\d+\.\d+)(?:,\s*\d+\.\d+)*)' This seems to fix ...

7 years, 4 months ago (2013-08-13 15:08:32 UTC) #1

benchen

LGTM++. This is probably the cleverest solution for now. Thanks.

7 years, 4 months ago (2013-08-13 15:12:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r10692.

Expand Messages | Collapse Messages