bench/bench_util.py - Issue 23069003: bench_util: allow optional whitespace in CSV format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/bench_util.py

Issue 23069003: bench_util: allow optional whitespace in CSV format (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/bench_util.py

===================================================================

--- bench/bench_util.py (revision 10690)

+++ bench/bench_util.py (working copy)

@@ -17,7 +17,7 @@

PER_SETTING_RE = '([^\s=]+)(?:=(\S+))?'

SETTINGS_RE = 'skia bench:((?:\s+' + PER_SETTING_RE + ')*)'

BENCH_RE = 'running bench (?:\[\d+ \d+\] )?\s*(\S+)'

-TIME_RE = '(?:(\w*)msecs = )?\s*((?:\d+\.\d+)(?:, \d+\.\d+)*)'

+TIME_RE = '(?:(\w*)msecs = )?\s*((?:\d+\.\d+)(?:,\s*\d+\.\d+)*)'

epoger 2013/08/13 15:08:32 This seems to fix it. To test, I ran this command

# non-per-tile benches have configs that don't end with ']' or '>'

CONFIG_RE = '(\S+[^\]>]): ((?:' + TIME_RE + '\s+)+)'

# per-tile bench lines are in the following format. Note that there are

« no previous file with comments | « no previous file | no next file » | no next file with comments »