Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer.

Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer.

invalidateCaret() once had another caller, but that day is long gone, as in, yesterday.

Committed: https://crrev.com/54a2101cb62839d7171cf907b611371b8ec6e8ee
Cr-Commit-Position: refs/heads/master@{#416420}

[wkorman, 2016-09-02 21:10:29]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-09-02 21:26:53]

https://codereview.chromium.org/2306813004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/2306813004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:932:
ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
On reflection I don't think we need line 932. If paint invalidation is not None
then needsRepaint
will be set by other means.

[wkorman, 2016-09-02 23:16:11]

Description was changed from

==========
Inline LayoutBlock::invalidateCaret.

It once had another caller, but that day is long gone, as in, yesterday.
==========

to

==========
Inline LayoutBlock::invalidateCaret and remove unnecessary setNeedsRepaint on
PaintLayer.

invalidateCaret() once had another caller, but that day is long gone, as in,
yesterday.
==========

[wkorman, 2016-09-02 23:17:04]

Description was changed from

==========
Inline LayoutBlock::invalidateCaret and remove unnecessary setNeedsRepaint on
PaintLayer.

invalidateCaret() once had another caller, but that day is long gone, as in,
yesterday.
==========

to

==========
Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer.

invalidateCaret() once had another caller, but that day is long gone, as in,
yesterday.
==========

[wkorman, 2016-09-02 23:17:36]

https://codereview.chromium.org/2306813004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right):

https://codereview.chromium.org/2306813004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlock.cpp:932:
ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
On 2016/09/02 21:26:53, chrishtr wrote:
> On reflection I don't think we need line 932. If paint invalidation is not
None
> then needsRepaint
> will be set by other means.

Done.

[chrishtr, 2016-09-02 23:25:41]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-02 23:25:42]

lgtm

[commit-bot: I haz the power, 2016-09-02 23:26:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:52:26]

Description was changed from

==========
Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer.

invalidateCaret() once had another caller, but that day is long gone, as in,
yesterday.
==========

to

==========
Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer.

invalidateCaret() once had another caller, but that day is long gone, as in,
yesterday.
==========

[commit-bot: I haz the power, 2016-09-03 00:52:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-03 00:55:27]

Description was changed from

==========
Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer.

invalidateCaret() once had another caller, but that day is long gone, as in,
yesterday.
==========

to

==========
Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer.

invalidateCaret() once had another caller, but that day is long gone, as in,
yesterday.

Committed: https://crrev.com/54a2101cb62839d7171cf907b611371b8ec6e8ee
Cr-Commit-Position: refs/heads/master@{#416420}
==========

[commit-bot: I haz the power, 2016-09-03 00:55:28]

Patchset 2 (id:??) landed as
https://crrev.com/54a2101cb62839d7171cf907b611371b8ec6e8ee
Cr-Commit-Position: refs/heads/master@{#416420}