Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 2306813004: Inline LayoutBlock::invalidateCaret and remove redundant needs-repaint on layer. (Closed)
Patch Set: Remove extraneous layer setNeedsRepaint. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 bool isPointInOverflowControl(HitTestResult&, const LayoutPoint& locationInC ontainer, const LayoutPoint& accumulatedOffset) const; 354 bool isPointInOverflowControl(HitTestResult&, const LayoutPoint& locationInC ontainer, const LayoutPoint& accumulatedOffset) const;
355 355
356 void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutU nit& maxLogicalWidth) const; 356 void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutU nit& maxLogicalWidth) const;
357 357
358 bool isSelectionRoot() const; 358 bool isSelectionRoot() const;
359 359
360 public: 360 public:
361 bool hasCursorCaret() const; 361 bool hasCursorCaret() const;
362 bool hasDragCaret() const; 362 bool hasDragCaret() const;
363 bool hasCaret() const { return hasCursorCaret() || hasDragCaret(); } 363 bool hasCaret() const { return hasCursorCaret() || hasDragCaret(); }
364 void invalidateCaret() const;
365 364
366 protected: 365 protected:
367 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override; 366 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override;
368 367
369 private: 368 private:
370 LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* extraWidt hToEndOfLine = nullptr) final; 369 LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* extraWidt hToEndOfLine = nullptr) final;
371 bool isInlineBoxWrapperActuallyChild() const; 370 bool isInlineBoxWrapperActuallyChild() const;
372 371
373 Position positionForBox(InlineBox*, bool start = true) const; 372 Position positionForBox(InlineBox*, bool start = true) const;
374 373
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 // This is necessary for now for interoperability between the old and new 424 // This is necessary for now for interoperability between the old and new
426 // layout code. Primarily for calling layoutPositionedObjects at the moment. 425 // layout code. Primarily for calling layoutPositionedObjects at the moment.
427 friend class NGBox; 426 friend class NGBox;
428 }; 427 };
429 428
430 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 429 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
431 430
432 } // namespace blink 431 } // namespace blink
433 432
434 #endif // LayoutBlock_h 433 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698