Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 230673002: Fix symmetry of Maybe() predicate. Fix bug in NowContains() predicate. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix symmetry of Maybe() predicate. Fix bug in NowContains() predicate. Add tests for TypeImpl::Of(), TypeImpl::NowOf() and TypeImpl::NowContains(). Improves the implementation of TypeImpl::NowIs() to match that of TypeImpl::NowContains(). Mark test-types with NO_VARIANTS to speedup testing, since the variants do not affect the type system at all. Also improve test coverage for types. TEST=cctest/test-types R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20639

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge patch from 230893002 #

Patch Set 3 : Tweaking test-types #

Patch Set 4 : Merge patch from issue 230903004 #

Patch Set 5 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -217 lines) Patch
M src/types.cc View 1 2 3 3 chunks +24 lines, -17 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-types.cc View 1 2 3 4 24 chunks +166 lines, -200 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Work in progress
6 years, 8 months ago (2014-04-09 11:52:28 UTC) #1
rossberg
LGTM https://codereview.chromium.org/230673002/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/230673002/diff/1/test/cctest/test-types.cc#newcode94 test/cctest/test-types.cc:94: size_t i = rand() % types.size(); I thought ...
6 years, 8 months ago (2014-04-09 13:59:10 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/230673002/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/230673002/diff/1/test/cctest/test-types.cc#newcode94 test/cctest/test-types.cc:94: size_t i = rand() % types.size(); Another CL...
6 years, 8 months ago (2014-04-10 05:19:16 UTC) #3
Benedikt Meurer
6 years, 8 months ago (2014-04-10 08:04:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r20639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698