Check the next chain of a slotchange event correctly on a slotchange at a fallback slot

Check the next chain of a slotchange event correctly on a slotchange at a fallback slot

When a slotchange event happens at a fallback slot, HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly.
It only checks whether the parent is a shadow host or not.

Instead of its own incomplete check logic, we should re-use Node::checkSlotChange()
here.

This also fixes a crash, reported by bug 642303, because needsDistributionRecalc
flag is set correctly by detecting the next chain of a slotchange event.

BUG=642303
Committed: https://crrev.com/4ab3573f362bbb835b25567448cc2c4b77427e12
Cr-Commit-Position: refs/heads/master@{#416491}

[hayato, 2016-09-02 10:47:34]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 10:47:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-02 10:50:46]

Description was changed from

==========
Check slotchange events recursively for a fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of slotchange correctly.

We should re-use Node::checkSlotChange() here, instead of its own check logic.

This also fixes the crash of bug 642303 because this CL sets
needsDistributionRecalc flag correctly.

BUG=642303
==========

to

==========
Check the next chain of a slotchange event for a fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly.

We should re-use the same check code used in Node::checkSlotChange() here, 
instead of its own check code.

This also fixes the crash of bug 642303 because this CL sets
needsDistributionRecalc
flag correctly.

BUG=642303
==========

[hayato, 2016-09-02 10:55:22]

Description was changed from

==========
Check the next chain of a slotchange event for a fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly.

We should re-use the same check code used in Node::checkSlotChange() here, 
instead of its own check code.

This also fixes the crash of bug 642303 because this CL sets
needsDistributionRecalc
flag correctly.

BUG=642303
==========

to

==========
Check the next chain of a slotchange event for a fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly. 
It only checks whether the parent is a shadow host.

Instead of its own incomplete check logic, we should re-use
Node::checkSlotChange()
here.

This also fixes the crash of bug 642303 because needsDistributionRecalc flag
will be
set correctly by detecting the next chain of a slotchange event.

BUG=642303
==========

[hayato, 2016-09-02 10:56:23]

Description was changed from

==========
Check the next chain of a slotchange event for a fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly. 
It only checks whether the parent is a shadow host.

Instead of its own incomplete check logic, we should re-use
Node::checkSlotChange()
here.

This also fixes the crash of bug 642303 because needsDistributionRecalc flag
will be
set correctly by detecting the next chain of a slotchange event.

BUG=642303
==========

to

==========
Check the next chain of a slotchange event for a fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly. 
It only checks whether the parent is a shadow host or not.

Instead of its own incomplete check logic, we should re-use
Node::checkSlotChange()
here.

This also fixes a crash, reported by bug 642303, because needsDistributionRecalc
flag is set correctly by detecting the next chain of a slotchange event.

BUG=642303
==========

[hayato, 2016-09-02 10:56:54]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org

[hayato, 2016-09-02 10:56:54]

PTAL

[hayato, 2016-09-02 10:58:33]

Description was changed from

==========
Check the next chain of a slotchange event for a fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly. 
It only checks whether the parent is a shadow host or not.

Instead of its own incomplete check logic, we should re-use
Node::checkSlotChange()
here.

This also fixes a crash, reported by bug 642303, because needsDistributionRecalc
flag is set correctly by detecting the next chain of a slotchange event.

BUG=642303
==========

to

==========
Check the next chain of a slotchange event correctly on a slotchange at a
fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly. 
It only checks whether the parent is a shadow host or not.

Instead of its own incomplete check logic, we should re-use
Node::checkSlotChange()
here.

This also fixes a crash, reported by bug 642303, because needsDistributionRecalc
flag is set correctly by detecting the next chain of a slotchange event.

BUG=642303
==========

[commit-bot: I haz the power, 2016-09-02 12:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 12:43:47]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kochi, 2016-09-02 14:58:02]

The direction to fix the issue sounds good, but it looks the new
layout test is failing.  Could you check?

[hayato, 2016-09-05 02:09:21]

Fix a test

[hayato, 2016-09-05 02:09:22]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 02:09:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-05 02:09:50]

On 2016/09/02 at 14:58:02, kochi wrote:
> The direction to fix the issue sounds good, but it looks the new
> layout test is failing.  Could you check?

Fixed.

[kochi, 2016-09-05 02:15:12]

lgtm

[hayato, 2016-09-05 03:26:57]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-09-05 03:26:59]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-09-05 03:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 03:43:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-05 03:45:44]

Description was changed from

==========
Check the next chain of a slotchange event correctly on a slotchange at a
fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly. 
It only checks whether the parent is a shadow host or not.

Instead of its own incomplete check logic, we should re-use
Node::checkSlotChange()
here.

This also fixes a crash, reported by bug 642303, because needsDistributionRecalc
flag is set correctly by detecting the next chain of a slotchange event.

BUG=642303
==========

to

==========
Check the next chain of a slotchange event correctly on a slotchange at a
fallback slot

When a slotchange event happens at a fallback slot,
HTMLSlotElement::enqueueSlotChangeEvent() does not check
the condition of the next chain of a slotchange correctly.
It only checks whether the parent is a shadow host or not.

Instead of its own incomplete check logic, we should re-use
Node::checkSlotChange()
here.

This also fixes a crash, reported by bug 642303, because needsDistributionRecalc
flag is set correctly by detecting the next chain of a slotchange event.

BUG=642303

Committed: https://crrev.com/4ab3573f362bbb835b25567448cc2c4b77427e12
Cr-Commit-Position: refs/heads/master@{#416491}
==========

[commit-bot: I haz the power, 2016-09-05 03:45:45]

Patchset 2 (id:??) landed as
https://crrev.com/4ab3573f362bbb835b25567448cc2c4b77427e12
Cr-Commit-Position: refs/heads/master@{#416491}