Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Issue 2306643004: Check the next chain of a slotchange event correctly on a slotchange at a fallback slot (Closed)
Patch Set: Fix a test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
index ee7300a11fa72921c1c503c42a1d24486d30e447..670f3fe39413bcc268ea6467c16628e6b1adf8ff 100644
--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
@@ -321,11 +321,8 @@ void HTMLSlotElement::enqueueSlotChangeEvent()
DCHECK(root);
DCHECK(root->isV1());
root->owner()->setNeedsDistributionRecalc();
-
- if (ShadowRoot* parentShadowRoot = v1ShadowRootOfParent()) {
- if (HTMLSlotElement* next = parentShadowRoot->ensureSlotAssignment().findSlot(*this))
- next->enqueueSlotChangeEvent();
- }
+ // Check slotchange recursively since this slotchange may cause another slotchange.
+ checkSlotChange();
}
bool HTMLSlotElement::hasAssignedNodesSlow() const
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698