Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2306583002: [turbofan] Fix typing rule for Math.sign. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typing rule for Math.sign. Committed: https://crrev.com/25504a220f75f88b565cf36df73c00e5f2702c65 Cr-Commit-Position: refs/heads/master@{#39103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/compiler/type-cache.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-math-sign-nan-type.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please?
4 years, 3 months ago (2016-09-01 13:12:47 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-01 18:43:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306583002/1
4 years, 3 months ago (2016-09-01 18:43:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 20:06:23 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:06:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25504a220f75f88b565cf36df73c00e5f2702c65
Cr-Commit-Position: refs/heads/master@{#39103}

Powered by Google App Engine
This is Rietveld 408576698