src/compiler/typer.cc - Issue 2306583002: [turbofan] Fix typing rule for Math.sign.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/typer.cc

Issue 2306583002: [turbofan] Fix typing rule for Math.sign. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/typer.cc

diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc

index 4f97772c8be20a0cb5b1553823d2abf749bab3f3..085b55482444f07d36c66c84efdbb0d2b276a486 100644

--- a/src/compiler/typer.cc

+++ b/src/compiler/typer.cc

@@ -1324,7 +1324,7 @@ Type* Typer::Visitor::JSCallFunctionTyper(Type* fun, Typer* t) {

case kMathTan:

return Type::Number();

case kMathSign:

- return t->cache_.kMinusOneToOne;

+ return t->cache_.kMinusOneToOneOrMinusZeroOrNaN;

// Binary math functions.

case kMathAtan2:

case kMathPow:

« no previous file with comments | « src/compiler/type-cache.h ('k') | test/mjsunit/compiler/regress-math-sign-nan-type.js » ('j') | no next file with comments »