Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2306443002: Remove GYP files from components. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, cbentzel+watch_chromium.org, oka+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, vabr+watchlistpasswordmanager_chromium.org, einbinder+watch-test-runner_chromium.org, posciak+watch_chromium.org, tfarina, yamaguchi+watch_chromium.org, fukino+watch_chromium.org, sync-reviews_chromium.org, dcheng, jochen+watch_chromium.org, noyau+watch_chromium.org, jlklein+watch-closure_chromium.org, devtools-reviews_chromium.org, vitalyp+closure_chromium.org, gcasto+watchlist_chromium.org, wifiprefetch-reviews_google.com, pfeldman, dbeam+watch-closure_chromium.org, tbarzic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GYP files from components. Inline sources lists in the two places they were shared with the GN build. TBR=dpranke@chromium.org Committed: https://crrev.com/e2ecbaf947b4f12fd585021a2c6033b2e1774711 Cr-Commit-Position: refs/heads/master@{#415891}

Patch Set 1 #

Patch Set 2 : Remove compiled resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -20179 lines) Patch
M .gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/about_handler.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/app_modal.gypi View 1 chunk +0 lines, -47 lines 0 comments Download
D components/arc.gypi View 1 chunk +0 lines, -244 lines 0 comments Download
D components/auto_login_parser.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D components/autofill.gypi View 1 chunk +0 lines, -669 lines 0 comments Download
D components/base32.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D components/bookmarks.gypi View 1 chunk +0 lines, -203 lines 0 comments Download
D components/browser_sync.gypi View 1 chunk +0 lines, -106 lines 0 comments Download
D components/browser_watcher.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
D components/browsing_data.gypi View 1 chunk +0 lines, -79 lines 0 comments Download
D components/browsing_data_ui.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/bubble.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D components/captive_portal.gypi View 1 chunk +0 lines, -48 lines 0 comments Download
D components/cast_certificate.gypi View 1 chunk +0 lines, -73 lines 0 comments Download
D components/cdm.gypi View 1 chunk +0 lines, -80 lines 0 comments Download
D components/certificate_reporting.gypi View 1 chunk +0 lines, -57 lines 0 comments Download
D components/certificate_transparency.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
D components/chrome_apps.gypi View 1 chunk +0 lines, -51 lines 0 comments Download
D components/client_update_protocol.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D components/cloud_devices.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
D components/component_updater.gypi View 1 chunk +0 lines, -61 lines 0 comments Download
D components/components.gyp View 1 chunk +0 lines, -211 lines 0 comments Download
D components/components_resources.gyp View 1 chunk +0 lines, -93 lines 0 comments Download
D components/components_strings.gyp View 1 chunk +0 lines, -51 lines 0 comments Download
D components/components_tests.gyp View 1 chunk +0 lines, -2147 lines 0 comments Download
D components/constrained_window.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D components/content_settings.gypi View 1 chunk +0 lines, -140 lines 0 comments Download
D components/contextual_search.gypi View 1 chunk +0 lines, -62 lines 0 comments Download
D components/cookie_config.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
D components/crash.gypi View 1 chunk +0 lines, -487 lines 0 comments Download
D components/cronet.gypi View 1 chunk +0 lines, -1013 lines 0 comments Download
D components/cronet/cronet_static.gypi View 1 chunk +0 lines, -90 lines 0 comments Download
D components/crx_file.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
D components/data_reduction_proxy.gypi View 1 chunk +0 lines, -304 lines 0 comments Download
D components/data_usage.gypi View 1 chunk +0 lines, -44 lines 0 comments Download
D components/data_use_measurement.gypi View 1 chunk +0 lines, -39 lines 0 comments Download
D components/device_event_log.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/devtools_discovery.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/devtools_http_handler.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/display_compositor.gypi View 1 chunk +0 lines, -116 lines 0 comments Download
D components/dom_distiller.gypi View 1 chunk +0 lines, -369 lines 0 comments Download
D components/domain_reliability.gypi View 1 chunk +0 lines, -92 lines 0 comments Download
M components/domain_reliability/BUILD.gn View 2 chunks +21 lines, -19 lines 0 comments Download
D components/domain_reliability/baked_in_configs.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/drive.gypi View 1 chunk +0 lines, -218 lines 0 comments Download
D components/error_page.gypi View 1 chunk +0 lines, -64 lines 0 comments Download
D components/exo.gypi View 1 chunk +0 lines, -125 lines 0 comments Download
D components/external_video_surface.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
D components/favicon.gypi View 1 chunk +0 lines, -112 lines 0 comments Download
D components/favicon_base.gypi View 1 chunk +0 lines, -45 lines 0 comments Download
D components/feedback.gypi View 1 chunk +0 lines, -71 lines 0 comments Download
D components/filesystem/filesystem.gyp View 1 chunk +0 lines, -72 lines 0 comments Download
D components/flags_ui.gypi View 1 chunk +0 lines, -79 lines 0 comments Download
D components/gcm_driver.gypi View 1 chunk +0 lines, -373 lines 0 comments Download
D components/google.gypi View 1 chunk +0 lines, -39 lines 0 comments Download
D components/guest_view.gypi View 1 chunk +0 lines, -99 lines 0 comments Download
D components/handoff.gypi View 1 chunk +0 lines, -33 lines 0 comments Download
D components/history.gypi View 1 chunk +0 lines, -267 lines 0 comments Download
D components/image_fetcher.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D components/infobars.gypi View 1 chunk +0 lines, -65 lines 0 comments Download
D components/invalidation.gypi View 1 chunk +0 lines, -269 lines 0 comments Download
D components/json_schema.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
D components/keyed_service.gypi View 1 chunk +0 lines, -111 lines 0 comments Download
D components/language_usage_metrics.gypi View 1 chunk +0 lines, -22 lines 0 comments Download
D components/leveldb/leveldb.gyp View 1 chunk +0 lines, -81 lines 0 comments Download
D components/leveldb_proto.gypi View 1 chunk +0 lines, -44 lines 0 comments Download
D components/link_header_util/link_header_util.gyp View 1 chunk +0 lines, -21 lines 0 comments Download
D components/login.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
D components/memory_coordinator.gypi View 1 chunk +0 lines, -65 lines 0 comments Download
D components/memory_pressure.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
D components/metrics.gypi View 1 chunk +0 lines, -361 lines 0 comments Download
D components/metrics_services_manager.gypi View 1 chunk +0 lines, -28 lines 0 comments Download
D components/mime_util/mime_util.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D components/nacl.gyp View 1 chunk +0 lines, -466 lines 0 comments Download
D components/nacl/renderer/plugin/plugin.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
D components/nacl_nonsfi.gyp View 1 chunk +0 lines, -303 lines 0 comments Download
D components/navigation_interception.gypi View 1 chunk +0 lines, -79 lines 0 comments Download
D components/navigation_metrics.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
D components/net_log.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D components/network_hints.gypi View 1 chunk +0 lines, -74 lines 0 comments Download
D components/network_session_configurator.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/network_time.gypi View 1 chunk +0 lines, -28 lines 0 comments Download
D components/ntp_snippets.gypi View 1 chunk +0 lines, -85 lines 0 comments Download
D components/ntp_tiles.gypi View 1 chunk +0 lines, -85 lines 0 comments Download
D components/offline_pages.gypi View 1 chunk +0 lines, -145 lines 0 comments Download
D components/omnibox.gypi View 1 chunk +0 lines, -222 lines 0 comments Download
D components/onc.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/open_from_clipboard.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D components/os_crypt.gypi View 1 chunk +0 lines, -140 lines 0 comments Download
D components/ownership.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
D components/packed_ct_ev_whitelist.gypi View 1 chunk +0 lines, -30 lines 0 comments Download
D components/pairing.gypi View 1 chunk +0 lines, -54 lines 0 comments Download
D components/password_manager.gypi View 1 chunk +0 lines, -368 lines 0 comments Download
D components/pdf.gypi View 1 chunk +0 lines, -66 lines 0 comments Download
D components/physical_web.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D components/plugins.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D components/policy.gypi View 1 chunk +0 lines, -598 lines 0 comments Download
D components/policy/policy_browser.gypi View 1 chunk +0 lines, -84 lines 0 comments Download
D components/policy/policy_common.gypi View 1 chunk +0 lines, -238 lines 0 comments Download
D components/power.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
D components/precache.gypi View 1 chunk +0 lines, -110 lines 0 comments Download
D components/precache/precache_defines.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D components/pref_registry.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D components/prefs/prefs.gyp View 1 chunk +0 lines, -89 lines 0 comments Download
D components/previews.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D components/printing.gypi View 1 chunk +0 lines, -82 lines 0 comments Download
D components/profile_metrics.gypi View 1 chunk +0 lines, -24 lines 0 comments Download
D components/proximity_auth.gypi View 1 chunk +0 lines, -270 lines 0 comments Download
D components/proxy_config.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D components/query_parser.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
D components/quirks.gypi View 1 chunk +0 lines, -36 lines 0 comments Download
D components/rappor.gypi View 1 chunk +0 lines, -76 lines 0 comments Download
D components/renderer_context_menu.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
D components/rlz.gypi View 1 chunk +0 lines, -38 lines 0 comments Download
D components/safe_browsing_db.gypi View 1 chunk +0 lines, -146 lines 0 comments Download
D components/safe_json.gypi View 1 chunk +0 lines, -127 lines 0 comments Download
D components/search.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/search_engines.gypi View 1 chunk +0 lines, -112 lines 0 comments Download
D components/search_engines/prepopulated_engines.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D components/search_provider_logos.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
D components/security_interstitials.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
D components/security_state.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
D components/session_manager.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/sessions.gypi View 1 chunk +0 lines, -167 lines 0 comments Download
D components/signin.gypi View 1 chunk +0 lines, -266 lines 0 comments Download
D components/spellcheck.gypi View 1 chunk +0 lines, -82 lines 0 comments Download
D components/ssl_config.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D components/ssl_errors.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D components/startup_metric_utils.gypi View 1 chunk +0 lines, -91 lines 0 comments Download
D components/storage_monitor.gypi View 1 chunk +0 lines, -132 lines 0 comments Download
D components/subresource_filter.gypi View 1 chunk +0 lines, -227 lines 0 comments Download
D components/suggestions.gypi View 1 chunk +0 lines, -59 lines 0 comments Download
D components/supervised_user_error_page.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D components/sync.gyp View 1 chunk +0 lines, -702 lines 0 comments Download
M components/sync/BUILD.gn View 10 chunks +0 lines, -10 lines 0 comments Download
D components/sync/protocol/protocol.gypi View 1 chunk +0 lines, -60 lines 0 comments Download
M components/sync/protocol/protocol_sources.gni View 1 chunk +46 lines, -10 lines 0 comments Download
D components/sync/sync_android.gypi View 1 chunk +0 lines, -59 lines 0 comments Download
D components/sync/sync_tests.gypi View 1 chunk +0 lines, -408 lines 0 comments Download
D components/sync/tools/sync_tools.gyp View 1 chunk +0 lines, -78 lines 0 comments Download
D components/sync_bookmarks.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
D components/sync_sessions.gypi View 1 chunk +0 lines, -97 lines 0 comments Download
D components/syncable_prefs.gypi View 1 chunk +0 lines, -64 lines 0 comments Download
D components/test_runner/test_runner.gyp View 1 chunk +0 lines, -226 lines 0 comments Download
D components/timers.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D components/toolbar.gypi View 1 chunk +0 lines, -63 lines 0 comments Download
D components/tracing.gyp View 1 chunk +0 lines, -118 lines 0 comments Download
D components/tracing_nacl.gyp View 1 chunk +0 lines, -52 lines 0 comments Download
D components/translate.gypi View 1 chunk +0 lines, -257 lines 0 comments Download
D components/undo.gypi View 1 chunk +0 lines, -33 lines 0 comments Download
D components/update_client.gypi View 1 chunk +0 lines, -98 lines 0 comments Download
D components/upload_list.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
D components/url_formatter/url_formatter.gyp View 1 chunk +0 lines, -84 lines 0 comments Download
D components/url_matcher.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D components/user_manager.gypi View 1 chunk +0 lines, -84 lines 0 comments Download
D components/user_prefs.gypi View 1 chunk +0 lines, -101 lines 0 comments Download
D components/variations.gypi View 1 chunk +0 lines, -179 lines 0 comments Download
D components/version_info.gypi View 1 chunk +0 lines, -94 lines 0 comments Download
D components/version_ui.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/visitedlink.gypi View 1 chunk +0 lines, -66 lines 0 comments Download
D components/wallpaper.gypi View 1 chunk +0 lines, -47 lines 0 comments Download
D components/web_cache.gypi View 1 chunk +0 lines, -48 lines 0 comments Download
D components/web_contents_delegate_android.gypi View 1 chunk +0 lines, -76 lines 0 comments Download
D components/web_modal.gypi View 1 chunk +0 lines, -48 lines 0 comments Download
D components/web_resource.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
D components/web_restrictions.gypi View 1 chunk +0 lines, -119 lines 0 comments Download
D components/webcrypto/webcrypto.gyp View 1 chunk +0 lines, -69 lines 0 comments Download
D components/webdata.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D components/webdata_services.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
D components/wifi.gypi View 1 chunk +0 lines, -81 lines 0 comments Download
D components/wifi_sync.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
D components/zoom.gypi View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306443002/1
4 years, 3 months ago (2016-08-31 23:18:29 UTC) #2
Dan Beam
sure hope nobody needs those compiled_resources.gyp
4 years, 3 months ago (2016-08-31 23:45:42 UTC) #3
Dirk Pranke
i.e., that file probably shouldn't be deleted yet.
4 years, 3 months ago (2016-08-31 23:47:16 UTC) #5
brettw
Remove compiled resources
4 years, 3 months ago (2016-08-31 23:54:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306443002/20001
4 years, 3 months ago (2016-08-31 23:55:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/290315)
4 years, 3 months ago (2016-09-01 01:21:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306443002/20001
4 years, 3 months ago (2016-09-01 04:35:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 05:52:34 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 05:54:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2ecbaf947b4f12fd585021a2c6033b2e1774711
Cr-Commit-Position: refs/heads/master@{#415891}

Powered by Google App Engine
This is Rietveld 408576698