Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: components/version_info.gypi

Issue 2306443002: Remove GYP files from components. (Closed)
Patch Set: Remove compiled resources Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations.gypi ('k') | components/version_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_info.gypi
diff --git a/components/version_info.gypi b/components/version_info.gypi
deleted file mode 100644
index d81d85d3935c1d353d24936cd6e312af8ad09962..0000000000000000000000000000000000000000
--- a/components/version_info.gypi
+++ /dev/null
@@ -1,94 +0,0 @@
-# Copyright 2015 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-{
- 'variables': {
- 'conditions': [
- ['branding == "Chrome"', {
- 'use_unofficial_version_number%': 0,
- }, {
- 'use_unofficial_version_number%': 1,
- }],
- ],
- },
- 'targets': [
- {
- # GN version: //components/version_info
- 'target_name': 'version_info',
- 'type': 'static_library',
- 'include_dirs': [
- '..',
- ],
- 'dependencies': [
- '../base/base.gyp:base',
- 'components_strings.gyp:components_strings',
- 'generate_version_info',
- ],
- 'sources': [
- 'version_info/version_info.cc',
- 'version_info/version_info.h',
- ],
- 'conditions': [
- ['use_unofficial_version_number==1', {
- 'dependencies': [
- '../ui/base/ui_base.gyp:ui_base',
- ],
- 'defines': ['USE_UNOFFICIAL_VERSION_NUMBER'],
- }],
- ],
- },
- {
- # GN version: //components/version_info:generate_version
- 'target_name': 'generate_version_info',
- 'type': 'none',
- 'direct_dependent_settings': {
- 'include_dirs': [
- '<(SHARED_INTERMEDIATE_DIR)',
- ],
- },
- # Because generate_version_info generates a header, the target must set
- # the hard_dependency flag.
- 'hard_dependency': 1,
- 'actions': [
- {
- 'action_name': 'generation_version_info',
- 'message': 'Generating version information',
- 'variables': {
- 'extra_version_flags': [],
- 'lastchange_path': '../build/util/LASTCHANGE',
- 'version_py_path': '../build/util/version.py',
- 'template_input_path': 'version_info/version_info_values.h.version',
- # Use VERSION and BRANDING files from //chrome even if this is bad
- # dependency until they are moved to src/ for VERSION and to the
- # version_info component for BRANDING. Synchronisation with TPM and
- # all release script is required for thoses moves. They are tracked
- # by issues http://crbug.com/512347 and http://crbug.com/513603.
- 'version_path': '../chrome/VERSION',
- 'branding_path': '../chrome/app/theme/<(branding_path_component)/BRANDING',
- },
- 'inputs': [
- '<(version_py_path)',
- '<(template_input_path)',
- '<(version_path)',
- '<(branding_path)',
- '<(lastchange_path)',
- ],
- 'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/components/version_info/version_info_values.h',
- ],
- 'action': [
- 'python',
- '<(version_py_path)',
- '-f', '<(version_path)',
- '-f', '<(branding_path)',
- '-f', '<(lastchange_path)',
- '<@(extra_version_flags)',
- '<(template_input_path)',
- '<@(_outputs)',
- ],
- },
- ],
- },
- ],
-}
« no previous file with comments | « components/variations.gypi ('k') | components/version_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698