Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 23064019: Follow-up changes for bug 257965 (writing-mode on first region). (Closed)

Created:
7 years, 4 months ago by mstensho (USE GERRIT)
Modified:
7 years, 3 months ago
Reviewers:
esprehn, mihnea
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, chromiumbugtracker_adobe.com, leviw+renderwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Follow-up changes for bug 257965 (writing-mode on first region). Some additional issues were raised and handled during code-review on the WebKit side: Add tests where the first region element is invalid and sets writing-mode. It's invalid because it's inside the same flow thread that it tries to flow from. Coding-style adjustments. Call RefPtr::release(). https://bugs.webkit.org/show_bug.cgi?id=119795 BUG=257965 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -8 lines) Patch
LayoutTests/fast/regions/invalid-first-region-with-writing-mode.html View 1 chunk +16 lines, -0 lines 0 comments Download
LayoutTests/fast/regions/invalid-first-region-with-writing-mode-2.html View 1 chunk +18 lines, -0 lines 0 comments Download
LayoutTests/fast/regions/invalid-first-region-with-writing-mode-2-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
LayoutTests/fast/regions/invalid-first-region-with-writing-mode-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
Source/core/rendering/RenderNamedFlowThread.cpp View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mstensho (USE GERRIT)
I think it's desirable to keep the region code in WebKit and Blink as similar ...
7 years, 4 months ago (2013-08-19 18:49:19 UTC) #1
mihnea
On 2013/08/19 18:49:19, Morten Stenshorne wrote: > I think it's desirable to keep the region ...
7 years, 3 months ago (2013-08-27 13:38:27 UTC) #2
esprehn
LGTM
7 years, 3 months ago (2013-08-31 05:39:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/23064019/1
7 years, 3 months ago (2013-08-31 08:30:45 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-31 18:20:03 UTC) #5
Message was sent while issue was closed.
Change committed as 157034

Powered by Google App Engine
This is Rietveld 408576698