content/renderer/npapi/webplugin_impl.cc - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/npapi/webplugin_impl.cc

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/npapi/webplugin_impl.cc

diff --git a/content/renderer/npapi/webplugin_impl.cc b/content/renderer/npapi/webplugin_impl.cc

index 21e80b6b76e81d14647f4d64b5fb3f57bbeeddff..55d84665e6e59bc14d51f1c20384afeae5a94b74 100644

--- a/content/renderer/npapi/webplugin_impl.cc

+++ b/content/renderer/npapi/webplugin_impl.cc

@@ -716,7 +716,7 @@ WebPluginImpl::RoutingStatus WebPluginImpl::RouteToFrame(

if (strcmp(method, "GET") != 0) {

// We're only going to route HTTP/HTTPS requests

- if (!(complete_url.SchemeIs("http") || complete_url.SchemeIs("https")))

+ if (!complete_url.SchemeIsHttp())

return INVALID_URL;

}