Made date input field read "mm", "dd", "yyyy", or equivalents in other languages, instead of "blank…

Made date input field read "mm", "dd", "yyyy", or equivalents in other languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org, tkent@chromium.org, avi@chromium.org
TESTED=manually with Jaws

Committed: https://crrev.com/dbf3a1084aecbfb8b0ff684c0935ee994f2b80b3
Cr-Commit-Position: refs/heads/master@{#417111}

[nektarios, 2016-09-06 22:23:03]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 22:23:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-09-06 22:39:53]

lgtm

Thanks for getting to this so quickly.

https://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp (left):

https://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1331: // case
SeparatorRole:
Is this an unrelated change?

[blink-reviews, 2016-09-06 22:49:54]

ttps://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

<https://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Sour...>
> File third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
> (left):
>
>
https://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1331:
> // case SeparatorRole:
> Is this an unrelated change?

Sorry, I thought I reverted that.
I'll send out this in a different patch.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-09-06 22:49:54]

ttps://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

<https://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Sour...>
> File third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
> (left):
>
>
https://codereview.chromium.org/2306383005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp:1331:
> // case SeparatorRole:
> Is this an unrelated change?

Sorry, I thought I reverted that.
I'll send out this in a different patch.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2016-09-06 22:59:18]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-09-06 22:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2306383005/#ps40001
(title: "Reverted separator role change.")

[commit-bot: I haz the power, 2016-09-06 23:00:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 23:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:09:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nektarios, 2016-09-06 23:30:37]

Description was changed from

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience in Firefox.
BUG=643423
R=dtseng@chromium.org
TESTED=manually with Jaws
==========

to

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many
websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org
TESTED=manually with Jaws
==========

[nektarios, 2016-09-06 23:30:37]

nektar@chromium.org changed reviewers:
+ esprehn@chromium.org

[nektarios, 2016-09-06 23:32:08]

Description was changed from

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many
websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org
TESTED=manually with Jaws
==========

to

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many
websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org,
tkent@chromium.org
TESTED=manually with Jaws
==========

[nektarios, 2016-09-06 23:32:08]

nektar@chromium.org changed reviewers:
+ keishi@chromium.org, tkent@chromium.org

[nektarios, 2016-09-06 23:33:51]

@esprehn
Please review changes to content/child/
@tkent or @keishi
Please review a small change to the date input field.

[tkent, 2016-09-06 23:57:16]

lgtm.
I'm wonder if reading 'mm' would be helpful. However I trust AX team decision.

[esprehn, 2016-09-06 23:57:28]

Got some tests? :)

[tkent, 2016-09-07 00:00:12]

Some tests in LayoutTests/fast/forms/ are failing.  Need to update them.

[chromium-reviews, 2016-09-07 00:36:08]

On 9/6/2016 7:57 PM, tkent@chromium.org wrote:
> lgtm.
> I'm wonder if reading 'mm' would be helpful. However I trust AX team 
> decision.

Just FYI.
I believe it is because it matches visual experience. If something 
doesn't match the visual experience then users who use screen readers 
can't easily collaborate with users who don't.
Also, "mm", "dd" and "yyyy" are very prevalent. They are on almost all 
websites I ever visited that have a custom date picker so they shouldn't 
cause surprise.
"Blank" however creates some surprise, and in fact a bug was filed about it.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[blink-reviews, 2016-09-07 00:36:11]

On 9/6/2016 7:57 PM, tkent@chromium.org wrote:
> lgtm.
> I'm wonder if reading 'mm' would be helpful. However I trust AX team 
> decision.

Just FYI.
I believe it is because it matches visual experience. If something 
doesn't match the visual experience then users who use screen readers 
can't easily collaborate with users who don't.
Also, "mm", "dd" and "yyyy" are very prevalent. They are on almost all 
websites I ever visited that have a custom date picker so they shouldn't 
cause surprise.
"Blank" however creates some surprise, and in fact a bug was filed about it.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[blink-reviews, 2016-09-07 01:26:55]

Tests fixed. I think they should be enough for coverage, do you agree?

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-09-07 01:27:04]

Tests fixed. I think they should be enough for coverage, do you agree?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tkent, 2016-09-07 01:41:32]

On 2016/09/07 at 01:27:04, chromium-reviews wrote:
> Tests fixed. I think they should be enough for coverage, do you agree?

agree.  still lgtm

[nektarios, 2016-09-07 15:46:45]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 15:47:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 17:24:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2016-09-07 19:32:33]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-09-07 19:32:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org,
tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2306383005/#ps80001
(title: "Fixed test expectations.")

[commit-bot: I haz the power, 2016-09-07 19:33:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:39:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nektarios, 2016-09-07 20:16:00]

@tkent
Have you given me an LGTM. I think I am still missing an LGTM from somewhere.

[nektarios, 2016-09-07 20:18:07]

Description was changed from

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many
websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org,
tkent@chromium.org
TESTED=manually with Jaws
==========

to

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many
websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org,
tkent@chromium.org, avi@chromium.org
TESTED=manually with Jaws
==========

[nektarios, 2016-09-07 20:18:07]

nektar@chromium.org changed reviewers:
+ avi@chromium.org

[nektarios, 2016-09-07 20:18:51]

@avi
Could you approve changes to content/?
I removed an accessibility message string.

[Avi (use Gerrit), 2016-09-07 20:23:10]

lgtm

[nektarios, 2016-09-07 23:05:16]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:11:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-07 23:13:57]

Description was changed from

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many
websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org,
tkent@chromium.org, avi@chromium.org
TESTED=manually with Jaws
==========

to

==========
Made date input field read "mm", "dd", "yyyy", or equivalents in other
languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many
websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org,
tkent@chromium.org, avi@chromium.org
TESTED=manually with Jaws

Committed: https://crrev.com/dbf3a1084aecbfb8b0ff684c0935ee994f2b80b3
Cr-Commit-Position: refs/heads/master@{#417111}
==========

[commit-bot: I haz the power, 2016-09-07 23:13:59]

Patchset 5 (id:??) landed as
https://crrev.com/dbf3a1084aecbfb8b0ff684c0935ee994f2b80b3
Cr-Commit-Position: refs/heads/master@{#417111}