Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

Issue 2306383005: Made date input field read "mm", "dd", "yyyy", or equivalents in other languages, instead of "blank… (Closed)
Patch Set: Fixed test expectations. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp
index dd47b86b89dd22839ead171481ad490c634381f9..f7e04643c66121c64f8853c5abc5f32057bb11a9 100644
--- a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp
@@ -39,11 +39,6 @@ namespace blink {
using namespace HTMLNames;
-static String emptyValueAXText()
-{
- return Locale::defaultLocale().queryString(WebLocalizedString::AXDateTimeFieldEmptyValueText);
-}
-
DateTimeFieldElement::FieldOwner::~FieldOwner()
{
}
@@ -159,7 +154,7 @@ void DateTimeFieldElement::initialize(const AtomicString& pseudo, const String&
{
// On accessibility, DateTimeFieldElement acts like spin button.
setAttribute(roleAttr, AtomicString("spinbutton"));
- setAttribute(aria_valuetextAttr, AtomicString(emptyValueAXText()));
+ setAttribute(aria_valuetextAttr, AtomicString(visibleValue()));
setAttribute(aria_valueminAttr, AtomicString::number(axMinimum));
setAttribute(aria_valuemaxAttr, AtomicString::number(axMaximum));
@@ -227,12 +222,11 @@ void DateTimeFieldElement::updateVisibleValue(EventBehavior eventBehavior)
textNode->replaceWholeText(newVisibleValue);
if (hasValue()) {
- setAttribute(aria_valuetextAttr, AtomicString(newVisibleValue));
setAttribute(aria_valuenowAttr, AtomicString::number(valueForARIAValueNow()));
} else {
- setAttribute(aria_valuetextAttr, AtomicString(emptyValueAXText()));
removeAttribute(aria_valuenowAttr);
}
+ setAttribute(aria_valuetextAttr, AtomicString(newVisibleValue));
if (eventBehavior == DispatchEvent && m_fieldOwner)
m_fieldOwner->fieldValueChanged();

Powered by Google App Engine
This is Rietveld 408576698