Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2306303002: Ensure clean layout for the remaining call sites of plainText() (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure clean layout for the remaining call sites of plainText() This patch is a preparation for removing the update layout call from plainText() (DOM tree version). BUG=590369 Committed: https://crrev.com/e95cc58bbfec319029aa51866029ae4de55d8665 Cr-Commit-Position: refs/heads/master@{#416505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-05 05:06:31 UTC) #5
tkent
lgtm
4 years, 3 months ago (2016-09-05 05:38:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306303002/1
4 years, 3 months ago (2016-09-05 06:26:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 06:30:12 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 06:32:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e95cc58bbfec319029aa51866029ae4de55d8665
Cr-Commit-Position: refs/heads/master@{#416505}

Powered by Google App Engine
This is Rietveld 408576698