Issue 23063002: Add toSVGClipPathElement(), and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23063002: Add toSVGClipPathElement(), and use it (Closed)

Created:
7 years, 4 months ago by gyuyoung-inactive

Modified:
7 years, 4 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add toSVGClipPathElement(), and use it As a step to clean-up static_cast<SVGXXX>, static_cast<SVGClipPathElement*> also can be changed with toSVGClipPathElement(). As minor clean-up, this cl changes to use toSVGSVGElement() instead of static_cast<SVGSVGElement*>. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156069

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -9 lines)			Patch
M	Source/core/rendering/svg/RenderSVGResourceClipper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceClipper.cpp	View	6 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/core/svg/SVGClipPathElement.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

The code is ok, but you mean toSVGClipPathElement, right? > Add toSVGTextPathElement(), and use it

7 years, 4 months ago (2013-08-13 22:29:57 UTC) #2

gyuyoung-inactive

On 2013/08/13 22:29:57, tkent wrote: > The code is ok, but you mean toSVGClipPathElement, right? ...

7 years, 4 months ago (2013-08-14 00:21:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23063002/1

7 years, 4 months ago (2013-08-14 00:28:16 UTC) #5

Message was sent while issue was closed.

Change committed as 156069

Expand Messages | Collapse Messages