Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2306053002: Revert of [ios] Implemented LoadHtml w/o using data:// URLs. (Closed)

Created:
4 years, 3 months ago by noyau (Ping after 24h)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Implemented LoadHtml w/o using data:// URLs. (patchset #4 id:60001 of https://codereview.chromium.org/2295053003/ ) Reason for revert: Breaking iOS build. Original issue's description: > [ios] Implemented LoadHtml w/o using data:// URLs. > > This allows loading HTML and setting a specific URL (last part is needed > by suggestions tests, which currently use private API to set the URL). > > BUG=619687 > > Committed: https://crrev.com/7d93683d73e6bb131651275c752a0792f2733410 > Cr-Commit-Position: refs/heads/master@{#416151} TBR=jyquinn@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619687 Committed: https://crrev.com/e04917c2cced1a397c9f959f6f27a1b44e245899 Cr-Commit-Position: refs/heads/master@{#416246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -51 lines) Patch
M ios/web/public/test/web_test_with_web_state.h View 1 chunk +7 lines, -4 lines 0 comments Download
M ios/web/public/test/web_test_with_web_state.mm View 2 chunks +50 lines, -33 lines 0 comments Download
M ios/web/web_state/js/core_js_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +8 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
noyau (Ping after 24h)
Created Revert of [ios] Implemented LoadHtml w/o using data:// URLs.
4 years, 3 months ago (2016-09-02 12:40:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306053002/1
4 years, 3 months ago (2016-09-02 12:40:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 12:41:28 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e04917c2cced1a397c9f959f6f27a1b44e245899 Cr-Commit-Position: refs/heads/master@{#416246}
4 years, 3 months ago (2016-09-02 12:43:48 UTC) #6
noyau (Ping after 24h)
4 years, 3 months ago (2016-09-02 13:06:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2309433002/ by noyau@chromium.org.

The reason for reverting is: False alert. This was not the root cause.
Relanding. Sorry for the noise..

Powered by Google App Engine
This is Rietveld 408576698