Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: ios/web/public/test/web_test_with_web_state.h

Issue 2306053002: Revert of [ios] Implemented LoadHtml w/o using data:// URLs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/public/test/web_test_with_web_state.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/test/web_test_with_web_state.h
diff --git a/ios/web/public/test/web_test_with_web_state.h b/ios/web/public/test/web_test_with_web_state.h
index 1f01f185cf16dfd3b1bf2f22add2a4c8e1312d2a..8c26f2bdfa1ff8d04c6be88b622393ff73c142ba 100644
--- a/ios/web/public/test/web_test_with_web_state.h
+++ b/ios/web/public/test/web_test_with_web_state.h
@@ -30,12 +30,15 @@
void WillProcessTask(const base::PendingTask& pending_task) override;
void DidProcessTask(const base::PendingTask& pending_task) override;
- // Loads the specified HTML content with URL into the WebState.
- void LoadHtml(NSString* html, const GURL& url);
- // Loads the specified HTML content into the WebState, using test url name.
+ // Loads the specified HTML content into the WebController via public APIs.
void LoadHtml(NSString* html);
- // Loads the specified HTML content into the WebState, using test url name.
+ // Loads the specified HTML content into the WebController via public APIs.
void LoadHtml(const std::string& html);
+ // Loads |url| into the WebController via public APIs.
+ // Note if anyone uses this to load web pages from the live internet, the
+ // tests can be flaky / dependent on content and behavior beyond our control.
+ // Use this only when it's impossible to test with static HTML using LoadHtml.
+ void LoadURL(const GURL& url);
// Blocks until both known NSRunLoop-based and known message-loop-based
// background tasks have completed
void WaitForBackgroundTasks();
« no previous file with comments | « no previous file | ios/web/public/test/web_test_with_web_state.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698