Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 23060030: Temporarily disable optimization for StringWrappers to use native valueOf (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Temporarily disable optimization for StringWrappers to use native valueOf V8 stores this information directly in the map of the wrapper, however, it is not invalidated when the prototype of the wrapper is changed, so once the bit is set, it is no longer possible to override valueOf. This bug is currently hidden in Chrome since the i18n extension always modifies the String.prototype, and so the optimization never kicks in. Disabling the optimization temporarily allows for snapshotting i18n now. BUG=v8:2855 R=yangguo@chromium.org TEST=mjsunit/regress/regress-2855.js Committed: https://code.google.com/p/v8/source/detail?r=16292

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-2855.js View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-08-23 05:54:31 UTC) #1
Yang
On 2013/08/23 05:54:31, jochen wrote: LGTM. FYI I'm already working on a better fix of ...
7 years, 3 months ago (2013-08-23 11:30:00 UTC) #2
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-08-23 11:31:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16292.

Powered by Google App Engine
This is Rietveld 408576698