src/x64/full-codegen-x64.cc - Issue 23060030: Temporarily disable optimization for StringWrappers to use native valueOf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 23060030: Temporarily disable optimization for StringWrappers to use native valueOf (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: updates Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 6333e87bea1b6c2ed82cd2b4ea153dd0cc917890..9f2074c58c435921e8ef9295f90ca28df69a12bc 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -3007,10 +3007,6 @@ void FullCodeGenerator::EmitIsStringWrapperSafeForDefaultValueOf(

__ cmpq(rcx,

ContextOperand(rdx, Context::STRING_FUNCTION_PROTOTYPE_MAP_INDEX));

__ j(not_equal, if_false);

- // Set the bit in the map to indicate that it has been checked safe for

- // default valueOf and set true result.

- __ or_(FieldOperand(rbx, Map::kBitField2Offset),

- Immediate(1 << Map::kStringWrapperSafeForDefaultValueOf));

__ jmp(if_true);

PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);

« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | test/mjsunit/regress/regress-2855.js » ('j') | no next file with comments »