Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2305903003: DOM append(), prepend(), after(), before(), and replaceWith() should throw an exception if a Docume… (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
sof
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM append(), prepend(), after(), before(), and replaceWith() should throw an exception if a Document is specified as one of arguments. https://dom.spec.whatwg.org/#converting-nodes-into-a-node > 4. Otherwise, set node to a new DocumentFragment whose node document is > document, and then append each node in nodes, if any, to it. Rethrow any > exceptions. Our implementation convertNodesIntoNode() ignored exceptions in this step. BUG=632873 Committed: https://crrev.com/68903386758f2e1924448af26989fd47b327a145 Cr-Commit-Position: refs/heads/master@{#416196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/ChildNode/after.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ChildNode/before.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ChildNode/replace-with.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ParentNode/append.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/ParentNode/prepend.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 4 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
sigbjornf@, would you review this please?
4 years, 3 months ago (2016-09-02 04:49:53 UTC) #6
sof
lgtm
4 years, 3 months ago (2016-09-02 05:19:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305903003/1
4 years, 3 months ago (2016-09-02 05:34:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 05:38:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 05:39:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68903386758f2e1924448af26989fd47b327a145
Cr-Commit-Position: refs/heads/master@{#416196}

Powered by Google App Engine
This is Rietveld 408576698