DOM append(), prepend(), after(), before(), and replaceWith() should throw an exception if a Docume…

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 448 matching lines @@
     return nullptr;
 }
 
 static Node* nodeOrStringToNode(const NodeOrString& nodeOrString, Document& document)
 {
     if (nodeOrString.isNode())
         return nodeOrString.getAsNode();
     return Text::create(document, nodeOrString.getAsString());
 }
 
-static Node* convertNodesIntoNode(const HeapVector<NodeOrString>& nodes, Document& document)
+// Returns nullptr if an exception was thrown.
+static Node* convertNodesIntoNode(const HeapVector<NodeOrString>& nodes, Document& document, ExceptionState& exceptionState)
 {
     if (nodes.size() == 1)
         return nodeOrStringToNode(nodes[0], document);
 
     Node* fragment = DocumentFragment::create(document);
-    for (const NodeOrString& nodeOrString : nodes)
-        fragment->appendChild(nodeOrStringToNode(nodeOrString, document), ASSERT_NO_EXCEPTION);
+    for (const NodeOrString& nodeOrString : nodes) {
+        fragment->appendChild(nodeOrStringToNode(nodeOrString, document), exceptionState);
+        if (exceptionState.hadException())
+            return nullptr;
+    }
     return fragment;
 }
 
 void Node::prepend(const HeapVector<NodeOrString>& nodes, ExceptionState& exceptionState)
 {
-    Node* node = convertNodesIntoNode(nodes, document());
-    insertBefore(node, firstChild(), exceptionState);
+    if (Node* node = convertNodesIntoNode(nodes, document(), exceptionState))
+        insertBefore(node, firstChild(), exceptionState);
 }
 
 void Node::append(const HeapVector<NodeOrString>& nodes, ExceptionState& exceptionState)
 {
-    Node* node = convertNodesIntoNode(nodes, document());
-    appendChild(node, exceptionState);
+    if (Node* node = convertNodesIntoNode(nodes, document(), exceptionState))
+        appendChild(node, exceptionState);
 }
 
 void Node::before(const HeapVector<NodeOrString>& nodes, ExceptionState& exceptionState)
 {
     Node* parent = parentNode();
     if (!parent)
         return;
     Node* viablePreviousSibling = findViablePreviousSibling(*this, nodes);
-    Node* node = convertNodesIntoNode(nodes, document());
-    parent->insertBefore(node, viablePreviousSibling ? viablePreviousSibling->nextSibling() : parent->firstChild(), exceptionState);
+    if (Node* node = convertNodesIntoNode(nodes, document(), exceptionState))
+        parent->insertBefore(node, viablePreviousSibling ? viablePreviousSibling->nextSibling() : parent->firstChild(), exceptionState);
 }
 
 void Node::after(const HeapVector<NodeOrString>& nodes, ExceptionState& exceptionState)
 {
     Node* parent = parentNode();
     if (!parent)
         return;
     Node* viableNextSibling = findViableNextSibling(*this, nodes);
-    Node* node = convertNodesIntoNode(nodes, document());
-    parent->insertBefore(node, viableNextSibling, exceptionState);
+    if (Node* node = convertNodesIntoNode(nodes, document(), exceptionState))
+        parent->insertBefore(node, viableNextSibling, exceptionState);
 }
 
 void Node::replaceWith(const HeapVector<NodeOrString>& nodes, ExceptionState& exceptionState)
 {
     Node* parent = parentNode();
     if (!parent)
         return;
     Node* viableNextSibling = findViableNextSibling(*this, nodes);
-    Node* node = convertNodesIntoNode(nodes, document());
+    Node* node = convertNodesIntoNode(nodes, document(), exceptionState);
+    if (exceptionState.hadException())
+        return;
     if (parent == parentNode())
         parent->replaceChild(node, this, exceptionState);
     else
         parent->insertBefore(node, viableNextSibling, exceptionState);
 }
 
 void Node::remove(ExceptionState& exceptionState)
 {
     if (ContainerNode* parent = parentNode())
         parent->removeChild(this, exceptionState);
@@ skipping 1876 matching lines @@
     if (node) {
         std::stringstream stream;
         node->printNodePathTo(stream);
         LOG(INFO) << stream.str();
     } else {
         LOG(INFO) << "Cannot showNodePath for <null>";
     }
 }
 
 #endif