Remove ScopedVector from importer.

Remove ScopedVector from importer.

BUG=554289
Committed: https://crrev.com/d29d39c31c6c6bac7219dc457241d323a8b7bf9e
Cr-Commit-Position: refs/heads/master@{#416326}

[Avi (use Gerrit), 2016-09-01 20:41:35]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 20:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:55:29]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-09-01 21:44:10]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 21:44:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-01 22:32:31]

avi@chromium.org changed reviewers:
+ gab@chromium.org, pkasting@chromium.org

[Avi (use Gerrit), 2016-09-01 22:32:32]

gab@chromium.org: Please review changes in importer
pkasting@chromium.org: Please review changes in search_engines

[commit-bot: I haz the power, 2016-09-01 22:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:45:55]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-09-01 22:55:41]

LGTM

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
File chrome/browser/importer/firefox_importer_browsertest.cc (right):

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
chrome/browser/importer/firefox_importer_browsertest.cc:223: for (size_t i = 0;
i < template_urls.size(); ++i) {
Nit: While here: This loop (and the inner one, I think) could use range-based
for

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
File chrome/browser/importer/in_process_importer_bridge.cc (right):

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
chrome/browser/importer/in_process_importer_bridge.cc:100: // If TemplateURL
creation fails, returns an empty unique_ptr.
Nit: Maybe just "returns null"?

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
chrome/browser/importer/in_process_importer_bridge.cc:105: return
std::unique_ptr<TemplateURL>();
Nit: Does "return nullptr" not work?

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
File components/search_engines/template_url_parser.cc (right):

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.cc:145: // empty unique_ptr if
parsing failed or if the results were invalid for some
Nit: "This will be null"?

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.cc:311: return
std::unique_ptr<TemplateURL>();
Nit: return nullptr?

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.cc:329:
std::unique_ptr<TemplateURL> template_url(
Nit: () -> =

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.cc:335: return
std::unique_ptr<TemplateURL>();
Nit: return nullptr?

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
File components/search_engines/template_url_parser.h (right):

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.h:34: // TemplateURL, and returns
it.  Returns an empty unique_ptr if the data does
Nit: "Returns null"?

[Avi (use Gerrit), 2016-09-01 23:23:19]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:23:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-01 23:28:34]

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
File chrome/browser/importer/firefox_importer_browsertest.cc (right):

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
chrome/browser/importer/firefox_importer_browsertest.cc:223: for (size_t i = 0;
i < template_urls.size(); ++i) {
On 2016/09/01 22:55:41, Peter Kasting wrote:
> Nit: While here: This loop (and the inner one, I think) could use range-based
> for

Done.

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
File chrome/browser/importer/in_process_importer_bridge.cc (right):

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
chrome/browser/importer/in_process_importer_bridge.cc:100: // If TemplateURL
creation fails, returns an empty unique_ptr.
On 2016/09/01 22:55:41, Peter Kasting wrote:
> Nit: Maybe just "returns null"?

Done.

https://codereview.chromium.org/2305813002/diff/20001/chrome/browser/importer...
chrome/browser/importer/in_process_importer_bridge.cc:105: return
std::unique_ptr<TemplateURL>();
On 2016/09/01 22:55:41, Peter Kasting wrote:
> Nit: Does "return nullptr" not work?

Huh! Didn't think it would, so I didn't try that.

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
File components/search_engines/template_url_parser.cc (right):

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.cc:145: // empty unique_ptr if
parsing failed or if the results were invalid for some
On 2016/09/01 22:55:41, Peter Kasting wrote:
> Nit: "This will be null"?

Done.

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.cc:329:
std::unique_ptr<TemplateURL> template_url(
On 2016/09/01 22:55:41, Peter Kasting wrote:
> Nit: () -> =

Done.

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.cc:335: return
std::unique_ptr<TemplateURL>();
On 2016/09/01 22:55:41, Peter Kasting wrote:
> Nit: return nullptr?

Done.

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
File components/search_engines/template_url_parser.h (right):

https://codereview.chromium.org/2305813002/diff/20001/components/search_engin...
components/search_engines/template_url_parser.h:34: // TemplateURL, and returns
it.  Returns an empty unique_ptr if the data does
On 2016/09/01 22:55:41, Peter Kasting wrote:
> Nit: "Returns null"?

Done.

[commit-bot: I haz the power, 2016-09-02 00:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:12:15]

Dry run: This issue passed the CQ dry run.

[gab, 2016-09-02 19:46:16]

Neat, LVGTM! (and lgtm for the parser ;-))

[Avi (use Gerrit), 2016-09-02 19:55:26]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-09-02 19:55:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2305813002/#ps40001
(title: "pkasting")

[commit-bot: I haz the power, 2016-09-02 19:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 20:00:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 20:03:15]

Description was changed from

==========
Remove ScopedVector from importer.

BUG=554289
==========

to

==========
Remove ScopedVector from importer.

BUG=554289

Committed: https://crrev.com/d29d39c31c6c6bac7219dc457241d323a8b7bf9e
Cr-Commit-Position: refs/heads/master@{#416326}
==========

[commit-bot: I haz the power, 2016-09-02 20:03:16]

Patchset 3 (id:??) landed as
https://crrev.com/d29d39c31c6c6bac7219dc457241d323a8b7bf9e
Cr-Commit-Position: refs/heads/master@{#416326}