Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: components/search_engines/template_url_parser.h

Issue 2305813002: Remove ScopedVector from importer. (Closed)
Patch Set: pkasting Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_engines/template_url_fetcher.cc ('k') | components/search_engines/template_url_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search_engines/template_url_parser.h
diff --git a/components/search_engines/template_url_parser.h b/components/search_engines/template_url_parser.h
index ead5906b91861462f524f4b0e962f2e67f07bdc3..a878cc95dd342ae110b9f95a431e76535701c1cc 100644
--- a/components/search_engines/template_url_parser.h
+++ b/components/search_engines/template_url_parser.h
@@ -7,6 +7,7 @@
#include <stddef.h>
+#include <memory>
#include <string>
#include "base/macros.h"
@@ -30,19 +31,19 @@ class TemplateURLParser {
};
// Decodes the chunk of data representing a TemplateURL, creates the
- // TemplateURL, and returns it. The caller owns the returned object.
- // Returns NULL if data does not describe a valid TemplateURL, the
- // URLs referenced do not point to valid http/https resources, or for some
- // other reason we do not support the described TemplateURL.
- // |parameter_filter| can be used if you want to filter some parameters out of
- // the URL. For example, when importing from another browser, we remove any
- // parameter identifying that browser. If set to NULL, the URL is not
- // modified.
- static TemplateURL* Parse(const SearchTermsData& search_terms_data,
- bool show_in_default_list,
- const char* data,
- size_t length,
- ParameterFilter* parameter_filter);
+ // TemplateURL, and returns it. Returns null if the data does not describe a
+ // valid TemplateURL, the URLs referenced do not point to valid http/https
+ // resources, or for some other reason we do not support the described
+ // TemplateURL. |parameter_filter| can be used if you want to filter some
+ // parameters out of the URL. For example, when importing from another
+ // browser, we remove any parameter identifying that browser. If set to null,
+ // the URL is not modified.
+ static std::unique_ptr<TemplateURL> Parse(
+ const SearchTermsData& search_terms_data,
+ bool show_in_default_list,
+ const char* data,
+ size_t length,
+ ParameterFilter* parameter_filter);
private:
// No one should create one of these.
« no previous file with comments | « components/search_engines/template_url_fetcher.cc ('k') | components/search_engines/template_url_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698