Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2305693003: Converted Observatory json-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use JSONViewElement just for ServiceMap #

Patch Set 3 : Updated observatory_sources.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -258 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 3 chunks +0 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 3 chunks +7 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/json_view.dart View 4 chunks +85 lines, -20 lines 0 comments Download
D runtime/observatory/lib/src/elements/json_view.html View 1 chunk +0 lines, -13 lines 0 comments Download
D runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -98 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 3 months ago (2016-09-01 21:06:18 UTC) #2
rmacnak
lgtm
4 years, 3 months ago (2016-09-02 16:47:20 UTC) #3
cbernaschina
4 years, 3 months ago (2016-09-02 17:22:58 UTC) #4
cbernaschina
4 years, 3 months ago (2016-09-02 17:23:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b31829db24e034f12669589f74636a8ff8d171d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698