Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2305693003: Converted Observatory json-view element (Closed)
Patch Set: Updated observatory_sources.gypi Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 084c78bf180bdd1411edbdbf8d58aca5e1ddf8f5..c2eb89b943fbd9fdfb7faa667e2b8cb2de8fe6de 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -382,7 +382,7 @@ class InspectPage extends MatchingPage {
_instanceRepository,
pos: pos, queue: app.queue)
];
- } else if (obj.type == 'Object') {
+ } else if (obj is HeapObject) {
container.children = [
new ObjectViewElement(app.vm, obj.isolate, obj, app.events,
app.notifications,
@@ -400,9 +400,9 @@ class InspectPage extends MatchingPage {
app.notifications, queue: app.queue)
];
} else {
- ServiceObjectViewElement serviceElement =new Element.tag('service-view');
- serviceElement.object = obj;
- container.children = [serviceElement];
+ container.children = [
+ new JSONViewElement(obj, app.notifications, queue: app.queue)
+ ];
}
}
}
@@ -664,16 +664,14 @@ class ErrorViewPage extends Page {
ErrorViewPage(app) : super(app);
void onInstall() {
- if (element == null) {
- /// Lazily create page.
- element = new Element.tag('service-view');
- }
+ element = new ErrorViewElement(app.notifications,
+ app.lastErrorOrException as DartError,
+ queue: app.queue);
}
void _visit(Uri uri) {
assert(element != null);
assert(canVisit(uri));
- (element as ServiceObjectViewElement).object = app.lastErrorOrException;
}
// TODO(turnidge): How to test this page?
« no previous file with comments | « runtime/observatory/lib/src/app/application.dart ('k') | runtime/observatory/lib/src/elements/json_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698