Do not select old bookmarks in ntp_snippets::BookmarkSuggestionsProvider

components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc

Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
index bd1b3888a16364d4daa727474a3f5443a09841b7..e0503a7575151c48e1dcfb24fd20ce4b32b2d967 100644
--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
@@ -187,6 +187,10 @@ std::vector<const BookmarkNode*> GetRecentlyVisitedBookmarks(
   // Insert the first |max_count| items from |bookmarks| into |result|.
   std::vector<const BookmarkNode*> result;
   for (const RecentBookmark& bookmark : bookmarks) {
+    if (min_visit_time >
+        GetLastVisitDateForBookmark(bookmark.node, creation_date_fallback))

[Marc Treib, 2016/09/01 11:16:32]

I think this should be
if (!creation_date_fallback &&
    GetLastVisitDateForBookmark(...) < min_visit_time)

If the creation date fallback is enabled, we do want to show older bookmarks
too.

[vitaliii, 2016/09/01 11:38:43]

Done.

+      break;

[Marc Treib, 2016/09/01 11:16:32]

nit: braces if the condition doesn't fit on one line

[vitaliii, 2016/09/01 11:38:43]

Done.

+
     result.push_back(bookmark.node);
     if (result.size() >= static_cast<size_t>(max_count))
       break;