Do not select old bookmarks in ntp_snippets::BookmarkSuggestionsProvider

components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
@@ skipping 169 matching lines @@
   std::sort(bookmarks.begin(), bookmarks.end(),
             [creation_date_fallback](const RecentBookmark& a,
                                      const RecentBookmark& b) {
               return CompareBookmarksByLastVisitDate(a.node, b.node,
                                                      creation_date_fallback);
             });
 
   // Insert the first |max_count| items from |bookmarks| into |result|.
   std::vector<const BookmarkNode*> result;
   for (const RecentBookmark& bookmark : bookmarks) {
+    if (min_visit_time >
+        GetLastVisitDateForBookmark(bookmark.node, creation_date_fallback))

[Marc Treib, 2016/09/01 11:16:32]

I think this should be
if (!creation_date_fallback &&
    GetLastVisitDateForBookmark(...) < min_visit_time)

If the creation date fallback is enabled, we do want to show older bookmarks
too.

[vitaliii, 2016/09/01 11:38:43]

Done.

+      break;

[Marc Treib, 2016/09/01 11:16:32]

nit: braces if the condition doesn't fit on one line

[vitaliii, 2016/09/01 11:38:43]

Done.

+
     result.push_back(bookmark.node);
     if (result.size() >= static_cast<size_t>(max_count))
       break;
   }
   return result;
 }
 
 std::vector<const BookmarkNode*> GetDismissedBookmarksForDebugging(
     BookmarkModel* bookmark_model) {
   // Get all the bookmark URLs.
@@ skipping 20 matching lines @@
   // Insert into |result|.
   std::vector<const BookmarkNode*> result;
   for (const BookmarkModel::URLAndTitle& bookmark : bookmarks) {
     result.push_back(
         bookmark_model->GetMostRecentlyAddedUserNodeForURL(bookmark.url));
   }
   return result;
 }
 
 }  // namespace ntp_snippets