Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/compiler/access-builder.cc

Issue 2305573003: [Turbofan] Remove more Type representation dimension data. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index f7dbd54b5096dbf57a63efcbfa5e566c53494cab..86be5f1129d277187d4165a42e065cfa8ef28c12 100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -68,7 +68,7 @@ FieldAccess AccessBuilder::ForJSObjectInObjectProperty(Handle<Map> map,
FieldAccess access = {kTaggedBase,
offset,
MaybeHandle<Name>(),
- Type::Tagged(),
+ Type::Any(),
Benedikt Meurer 2016/09/02 07:31:30 Change this to Type::NonInternal()
mvstanton 2016/09/02 08:03:56 Done.
MachineType::AnyTagged(),
kFullWriteBarrier};
return access;
@@ -116,12 +116,9 @@ FieldAccess AccessBuilder::ForJSFunctionLiterals() {
// static
FieldAccess AccessBuilder::ForJSFunctionCodeEntry() {
- FieldAccess access = {kTaggedBase,
- JSFunction::kCodeEntryOffset,
- Handle<Name>(),
- Type::UntaggedPointer(),
- MachineType::Pointer(),
- kNoWriteBarrier};
+ FieldAccess access = {
+ kTaggedBase, JSFunction::kCodeEntryOffset, Handle<Name>(),
+ Type::Any(), MachineType::Pointer(), kNoWriteBarrier};
Benedikt Meurer 2016/09/02 07:31:29 Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
return access;
}
@@ -218,7 +215,7 @@ FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() {
FieldAccess access = {kTaggedBase,
JSArrayBuffer::kBackingStoreOffset,
MaybeHandle<Name>(),
- Type::UntaggedPointer(),
+ Type::Any(),
Benedikt Meurer 2016/09/02 07:31:30 This should also be Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
MachineType::Pointer(),
kNoWriteBarrier};
return access;
@@ -234,12 +231,9 @@ FieldAccess AccessBuilder::ForJSArrayBufferBitField() {
// static
FieldAccess AccessBuilder::ForJSArrayBufferViewBuffer() {
- FieldAccess access = {kTaggedBase,
- JSArrayBufferView::kBufferOffset,
- MaybeHandle<Name>(),
- Type::TaggedPointer(),
- MachineType::TaggedPointer(),
- kPointerWriteBarrier};
+ FieldAccess access = {
+ kTaggedBase, JSArrayBufferView::kBufferOffset, MaybeHandle<Name>(),
+ Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier};
Benedikt Meurer 2016/09/02 07:31:30 Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
return access;
}
@@ -320,8 +314,8 @@ FieldAccess AccessBuilder::ForJSIteratorResultValue() {
// static
FieldAccess AccessBuilder::ForJSRegExpFlags() {
FieldAccess access = {
- kTaggedBase, JSRegExp::kFlagsOffset, MaybeHandle<Name>(),
- Type::Tagged(), MachineType::AnyTagged(), kFullWriteBarrier};
+ kTaggedBase, JSRegExp::kFlagsOffset, MaybeHandle<Name>(),
+ Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier};
Benedikt Meurer 2016/09/02 07:31:29 Type::NonInternal()
mvstanton 2016/09/02 08:03:55 Done.
return access;
}
@@ -329,8 +323,8 @@ FieldAccess AccessBuilder::ForJSRegExpFlags() {
// static
FieldAccess AccessBuilder::ForJSRegExpSource() {
FieldAccess access = {
- kTaggedBase, JSRegExp::kSourceOffset, MaybeHandle<Name>(),
- Type::Tagged(), MachineType::AnyTagged(), kFullWriteBarrier};
+ kTaggedBase, JSRegExp::kSourceOffset, MaybeHandle<Name>(),
+ Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier};
Benedikt Meurer 2016/09/02 07:31:29 Type::NonInternal()
mvstanton 2016/09/02 08:03:55 Done.
return access;
}
@@ -351,7 +345,7 @@ FieldAccess AccessBuilder::ForFixedTypedArrayBaseBasePointer() {
FieldAccess access = {kTaggedBase,
FixedTypedArrayBase::kBasePointerOffset,
MaybeHandle<Name>(),
Benedikt Meurer 2016/09/02 07:31:30 Type::OtherInternal()
mvstanton 2016/09/02 08:03:55 Done.
- Type::Tagged(),
+ Type::Any(),
MachineType::AnyTagged(),
kPointerWriteBarrier};
return access;
@@ -362,7 +356,7 @@ FieldAccess AccessBuilder::ForFixedTypedArrayBaseExternalPointer() {
FieldAccess access = {kTaggedBase,
FixedTypedArrayBase::kExternalPointerOffset,
MaybeHandle<Name>(),
- Type::UntaggedPointer(),
+ Type::Any(),
Benedikt Meurer 2016/09/02 07:31:30 Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
MachineType::Pointer(),
kNoWriteBarrier};
return access;
@@ -370,12 +364,9 @@ FieldAccess AccessBuilder::ForFixedTypedArrayBaseExternalPointer() {
// static
FieldAccess AccessBuilder::ForDescriptorArrayEnumCache() {
- FieldAccess access = {kTaggedBase,
- DescriptorArray::kEnumCacheOffset,
- Handle<Name>(),
- Type::TaggedPointer(),
- MachineType::TaggedPointer(),
- kPointerWriteBarrier};
+ FieldAccess access = {
+ kTaggedBase, DescriptorArray::kEnumCacheOffset, Handle<Name>(),
+ Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier};
Benedikt Meurer 2016/09/02 07:31:30 Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
return access;
}
@@ -385,7 +376,7 @@ FieldAccess AccessBuilder::ForDescriptorArrayEnumCacheBridgeCache() {
FieldAccess access = {kTaggedBase,
DescriptorArray::kEnumCacheBridgeCacheOffset,
Handle<Name>(),
- Type::TaggedPointer(),
+ Type::Any(),
Benedikt Meurer 2016/09/02 07:31:30 Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
MachineType::TaggedPointer(),
kPointerWriteBarrier};
return access;
@@ -412,12 +403,9 @@ FieldAccess AccessBuilder::ForMapBitField3() {
// static
FieldAccess AccessBuilder::ForMapDescriptors() {
- FieldAccess access = {kTaggedBase,
- Map::kDescriptorsOffset,
- Handle<Name>(),
- Type::TaggedPointer(),
- MachineType::TaggedPointer(),
- kPointerWriteBarrier};
+ FieldAccess access = {
+ kTaggedBase, Map::kDescriptorsOffset, Handle<Name>(),
+ Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier};
Benedikt Meurer 2016/09/02 07:31:29 Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
return access;
}
@@ -433,12 +421,9 @@ FieldAccess AccessBuilder::ForMapInstanceType() {
// static
FieldAccess AccessBuilder::ForMapPrototype() {
- FieldAccess access = {kTaggedBase,
- Map::kPrototypeOffset,
- Handle<Name>(),
- Type::TaggedPointer(),
- MachineType::TaggedPointer(),
- kPointerWriteBarrier};
+ FieldAccess access = {
+ kTaggedBase, Map::kPrototypeOffset, Handle<Name>(),
+ Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier};
return access;
}
@@ -499,7 +484,7 @@ FieldAccess AccessBuilder::ForExternalStringResourceData() {
FieldAccess access = {kTaggedBase,
ExternalString::kResourceDataOffset,
Handle<Name>(),
- Type::UntaggedPointer(),
+ Type::Any(),
Benedikt Meurer 2016/09/02 07:31:30 Type::OtherInternal()
mvstanton 2016/09/02 08:03:56 Done.
MachineType::Pointer(),
kNoWriteBarrier};
return access;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698