[Turbofan] Remove more Type representation dimension data.

src/compiler/access-builder.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/access-builder.h"
 
 #include "src/compiler/type-cache.h"
 #include "src/contexts.h"
 #include "src/frames.h"
 #include "src/handles-inl.h"
@@ skipping 50 matching lines @@
 }
 
 
 // static
 FieldAccess AccessBuilder::ForJSObjectInObjectProperty(Handle<Map> map,
                                                        int index) {
   int const offset = map->GetInObjectPropertyOffset(index);
   FieldAccess access = {kTaggedBase,
                         offset,
                         MaybeHandle<Name>(),
-                        Type::Tagged(),
+                        Type::Any(),

[Benedikt Meurer, 2016/09/02 07:31:30]

Change this to Type::NonInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

                         MachineType::AnyTagged(),
                         kFullWriteBarrier};
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForJSFunctionPrototypeOrInitialMap() {
   FieldAccess access = {kTaggedBase,
                         JSFunction::kPrototypeOrInitialMapOffset,
@@ skipping 27 matching lines @@
 // static
 FieldAccess AccessBuilder::ForJSFunctionLiterals() {
   FieldAccess access = {
       kTaggedBase,      JSFunction::kLiteralsOffset, Handle<Name>(),
       Type::Internal(), MachineType::AnyTagged(),    kPointerWriteBarrier};
   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForJSFunctionCodeEntry() {
-  FieldAccess access = {kTaggedBase,
-                        JSFunction::kCodeEntryOffset,
-                        Handle<Name>(),
-                        Type::UntaggedPointer(),
-                        MachineType::Pointer(),
-                        kNoWriteBarrier};
+  FieldAccess access = {
+      kTaggedBase, JSFunction::kCodeEntryOffset, Handle<Name>(),
+      Type::Any(), MachineType::Pointer(),       kNoWriteBarrier};

[Benedikt Meurer, 2016/09/02 07:31:29]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForJSFunctionNextFunctionLink() {
   FieldAccess access = {kTaggedBase,
                         JSFunction::kNextFunctionLinkOffset,
                         Handle<Name>(),
                         Type::Any(),
                         MachineType::AnyTagged(),
@@ skipping 76 matching lines @@
   }
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() {
   FieldAccess access = {kTaggedBase,
                         JSArrayBuffer::kBackingStoreOffset,
                         MaybeHandle<Name>(),
-                        Type::UntaggedPointer(),
+                        Type::Any(),

[Benedikt Meurer, 2016/09/02 07:31:30]

This should also be Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

                         MachineType::Pointer(),
                         kNoWriteBarrier};
   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForJSArrayBufferBitField() {
   FieldAccess access = {kTaggedBase,           JSArrayBuffer::kBitFieldOffset,
                         MaybeHandle<Name>(),   TypeCache::Get().kUint8,
                         MachineType::Uint32(), kNoWriteBarrier};
   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForJSArrayBufferViewBuffer() {
-  FieldAccess access = {kTaggedBase,
-                        JSArrayBufferView::kBufferOffset,
-                        MaybeHandle<Name>(),
-                        Type::TaggedPointer(),
-                        MachineType::TaggedPointer(),
-                        kPointerWriteBarrier};
+  FieldAccess access = {
+      kTaggedBase, JSArrayBufferView::kBufferOffset, MaybeHandle<Name>(),
+      Type::Any(), MachineType::TaggedPointer(),     kPointerWriteBarrier};

[Benedikt Meurer, 2016/09/02 07:31:30]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForJSArrayBufferViewByteLength() {
   FieldAccess access = {kTaggedBase,
                         JSArrayBufferView::kByteLengthOffset,
                         MaybeHandle<Name>(),
                         TypeCache::Get().kPositiveInteger,
                         MachineType::AnyTagged(),
@@ skipping 60 matching lines @@
   FieldAccess access = {
       kTaggedBase,         JSIteratorResult::kValueOffset, MaybeHandle<Name>(),
       Type::NonInternal(), MachineType::AnyTagged(),       kFullWriteBarrier};
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForJSRegExpFlags() {
   FieldAccess access = {
-      kTaggedBase,    JSRegExp::kFlagsOffset,   MaybeHandle<Name>(),
-      Type::Tagged(), MachineType::AnyTagged(), kFullWriteBarrier};
+      kTaggedBase, JSRegExp::kFlagsOffset,   MaybeHandle<Name>(),
+      Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier};

[Benedikt Meurer, 2016/09/02 07:31:29]

Type::NonInternal()

[mvstanton, 2016/09/02 08:03:55]

Done.

   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForJSRegExpSource() {
   FieldAccess access = {
-      kTaggedBase,    JSRegExp::kSourceOffset,  MaybeHandle<Name>(),
-      Type::Tagged(), MachineType::AnyTagged(), kFullWriteBarrier};
+      kTaggedBase, JSRegExp::kSourceOffset,  MaybeHandle<Name>(),
+      Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier};

[Benedikt Meurer, 2016/09/02 07:31:29]

Type::NonInternal()

[mvstanton, 2016/09/02 08:03:55]

Done.

   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForFixedArrayLength() {
   FieldAccess access = {kTaggedBase,
                         FixedArray::kLengthOffset,
                         MaybeHandle<Name>(),
                         TypeCache::Get().kFixedArrayLengthType,
                         MachineType::TaggedSigned(),
                         kNoWriteBarrier};
   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForFixedTypedArrayBaseBasePointer() {
   FieldAccess access = {kTaggedBase,
                         FixedTypedArrayBase::kBasePointerOffset,
                         MaybeHandle<Name>(),

[Benedikt Meurer, 2016/09/02 07:31:30]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:55]

Done.

-                        Type::Tagged(),
+                        Type::Any(),
                         MachineType::AnyTagged(),
                         kPointerWriteBarrier};
   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForFixedTypedArrayBaseExternalPointer() {
   FieldAccess access = {kTaggedBase,
                         FixedTypedArrayBase::kExternalPointerOffset,
                         MaybeHandle<Name>(),
-                        Type::UntaggedPointer(),
+                        Type::Any(),

[Benedikt Meurer, 2016/09/02 07:31:30]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

                         MachineType::Pointer(),
                         kNoWriteBarrier};
   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForDescriptorArrayEnumCache() {
-  FieldAccess access = {kTaggedBase,
-                        DescriptorArray::kEnumCacheOffset,
-                        Handle<Name>(),
-                        Type::TaggedPointer(),
-                        MachineType::TaggedPointer(),
-                        kPointerWriteBarrier};
+  FieldAccess access = {
+      kTaggedBase, DescriptorArray::kEnumCacheOffset, Handle<Name>(),
+      Type::Any(), MachineType::TaggedPointer(),      kPointerWriteBarrier};

[Benedikt Meurer, 2016/09/02 07:31:30]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForDescriptorArrayEnumCacheBridgeCache() {
   FieldAccess access = {kTaggedBase,
                         DescriptorArray::kEnumCacheBridgeCacheOffset,
                         Handle<Name>(),
-                        Type::TaggedPointer(),
+                        Type::Any(),

[Benedikt Meurer, 2016/09/02 07:31:30]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

                         MachineType::TaggedPointer(),
                         kPointerWriteBarrier};
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForMapBitField() {
   FieldAccess access = {kTaggedBase,          Map::kBitFieldOffset,
                         Handle<Name>(),       TypeCache::Get().kUint8,
                         MachineType::Uint8(), kNoWriteBarrier};
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForMapBitField3() {
   FieldAccess access = {kTaggedBase,          Map::kBitField3Offset,
                         Handle<Name>(),       TypeCache::Get().kInt32,
                         MachineType::Int32(), kNoWriteBarrier};
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForMapDescriptors() {
-  FieldAccess access = {kTaggedBase,
-                        Map::kDescriptorsOffset,
-                        Handle<Name>(),
-                        Type::TaggedPointer(),
-                        MachineType::TaggedPointer(),
-                        kPointerWriteBarrier};
+  FieldAccess access = {
+      kTaggedBase, Map::kDescriptorsOffset,      Handle<Name>(),
+      Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier};

[Benedikt Meurer, 2016/09/02 07:31:29]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForMapInstanceType() {
   FieldAccess access = {kTaggedBase,          Map::kInstanceTypeOffset,
                         Handle<Name>(),       TypeCache::Get().kUint8,
                         MachineType::Uint8(), kNoWriteBarrier};
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForMapPrototype() {
-  FieldAccess access = {kTaggedBase,
-                        Map::kPrototypeOffset,
-                        Handle<Name>(),
-                        Type::TaggedPointer(),
-                        MachineType::TaggedPointer(),
-                        kPointerWriteBarrier};
+  FieldAccess access = {
+      kTaggedBase, Map::kPrototypeOffset,        Handle<Name>(),
+      Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier};
   return access;
 }
 
 
 // static
 FieldAccess AccessBuilder::ForNameHashField() {
   FieldAccess access = {kTaggedBase,           Name::kHashFieldOffset,
                         Handle<Name>(),        Type::Internal(),
                         MachineType::Uint32(), kNoWriteBarrier};
   return access;
@@ skipping 40 matching lines @@
       kTaggedBase,    SlicedString::kParentOffset, Handle<Name>(),
       Type::String(), MachineType::AnyTagged(),    kPointerWriteBarrier};
   return access;
 }
 
 // static
 FieldAccess AccessBuilder::ForExternalStringResourceData() {
   FieldAccess access = {kTaggedBase,
                         ExternalString::kResourceDataOffset,
                         Handle<Name>(),
-                        Type::UntaggedPointer(),
+                        Type::Any(),

[Benedikt Meurer, 2016/09/02 07:31:30]

Type::OtherInternal()

[mvstanton, 2016/09/02 08:03:56]

Done.

                         MachineType::Pointer(),
                         kNoWriteBarrier};
   return access;
 }
 
 // static
 ElementAccess AccessBuilder::ForExternalOneByteStringCharacter() {
   ElementAccess access = {kUntaggedBase, 0, TypeCache::Get().kUint8,
                           MachineType::Uint8(), kNoWriteBarrier};
   return access;
@@ skipping 226 matching lines @@
   }
   UNREACHABLE();
   ElementAccess access = {kUntaggedBase, 0, Type::None(), MachineType::None(),
                           kNoWriteBarrier};
   return access;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8