Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2305573003:
[Turbofan] Remove more Type representation dimension data. (Closed)
|
Created:
4 years, 3 months ago by mvstanton Modified:
4 years, 3 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Turbofan] Remove more Type representation dimension data.
Happily, we can/should include semantic information such as Internal(), NonInternal() even as we remove representation data.
BUG=
Committed: https://crrev.com/3d617c1661909cd48b66359ef734e6361663d2d1
Cr-Commit-Position: refs/heads/master@{#39123}
Patch Set 1 #
Total comments: 24
Patch Set 2 : Comments. #Patch Set 3 : Missed one. #Messages
Total messages: 15 (9 generated)
bmeurer@chromium.org changed reviewers: + bmeurer@chromium.org
https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder.cc File src/compiler/access-builder.cc (right): https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:71: Type::Any(), Change this to Type::NonInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:121: Type::Any(), MachineType::Pointer(), kNoWriteBarrier}; Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:218: Type::Any(), This should also be Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:236: Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier}; Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:318: Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier}; Type::NonInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:327: Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier}; Type::NonInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:347: MaybeHandle<Name>(), Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:359: Type::Any(), Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:369: Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier}; Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:379: Type::Any(), Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:408: Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier}; Type::OtherInternal() https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:487: Type::Any(), Type::OtherInternal()
Description was changed from ========== [Turbofan] Remove more Type representation dimension data. BUG= ========== to ========== [Turbofan] Remove more Type representation dimension data. Happily, we can/should include semantic information such as Internal(), NonInternal() even as we remove representation data. BUG= ==========
Hi Benedikt, Thanks for the tutorial. Have a quick look, --Mike https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder.cc File src/compiler/access-builder.cc (right): https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:71: Type::Any(), On 2016/09/02 07:31:30, Benedikt Meurer wrote: > Change this to Type::NonInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:121: Type::Any(), MachineType::Pointer(), kNoWriteBarrier}; On 2016/09/02 07:31:29, Benedikt Meurer wrote: > Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:218: Type::Any(), On 2016/09/02 07:31:30, Benedikt Meurer wrote: > This should also be Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:236: Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier}; On 2016/09/02 07:31:30, Benedikt Meurer wrote: > Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:318: Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier}; On 2016/09/02 07:31:29, Benedikt Meurer wrote: > Type::NonInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:327: Type::Any(), MachineType::AnyTagged(), kFullWriteBarrier}; On 2016/09/02 07:31:29, Benedikt Meurer wrote: > Type::NonInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:347: MaybeHandle<Name>(), On 2016/09/02 07:31:30, Benedikt Meurer wrote: > Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:359: Type::Any(), On 2016/09/02 07:31:30, Benedikt Meurer wrote: > Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:369: Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier}; On 2016/09/02 07:31:30, Benedikt Meurer wrote: > Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:379: Type::Any(), On 2016/09/02 07:31:30, Benedikt Meurer wrote: > Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:408: Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier}; On 2016/09/02 07:31:29, Benedikt Meurer wrote: > Type::OtherInternal() Done. https://codereview.chromium.org/2305573003/diff/1/src/compiler/access-builder... src/compiler/access-builder.cc:487: Type::Any(), On 2016/09/02 07:31:30, Benedikt Meurer wrote: > Type::OtherInternal() Done.
The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM.
The CQ bit was checked by mvstanton@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] Remove more Type representation dimension data. Happily, we can/should include semantic information such as Internal(), NonInternal() even as we remove representation data. BUG= ========== to ========== [Turbofan] Remove more Type representation dimension data. Happily, we can/should include semantic information such as Internal(), NonInternal() even as we remove representation data. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] Remove more Type representation dimension data. Happily, we can/should include semantic information such as Internal(), NonInternal() even as we remove representation data. BUG= ========== to ========== [Turbofan] Remove more Type representation dimension data. Happily, we can/should include semantic information such as Internal(), NonInternal() even as we remove representation data. BUG= Committed: https://crrev.com/3d617c1661909cd48b66359ef734e6361663d2d1 Cr-Commit-Position: refs/heads/master@{#39123} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/3d617c1661909cd48b66359ef734e6361663d2d1 Cr-Commit-Position: refs/heads/master@{#39123} |
