Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2305483002: Add missing dependency in the rule which generates io_gen.cc (Closed)

Created:
4 years, 3 months ago by siva
Modified:
4 years, 3 months ago
Reviewers:
zra, jsimmons1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/BUILD.gn View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
siva
4 years, 3 months ago (2016-09-01 00:00:31 UTC) #2
jsimmons1
LGTM https://codereview.chromium.org/2305483002/diff/1/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2305483002/diff/1/runtime/bin/BUILD.gn#newcode56 runtime/bin/BUILD.gn:56: ] + invoker.sources Other actions in this file ...
4 years, 3 months ago (2016-09-01 00:08:34 UTC) #3
zra
lgtm
4 years, 3 months ago (2016-09-01 14:53:13 UTC) #4
siva
https://codereview.chromium.org/2305483002/diff/1/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2305483002/diff/1/runtime/bin/BUILD.gn#newcode56 runtime/bin/BUILD.gn:56: ] + invoker.sources On 2016/09/01 00:08:34, jsimmons1 wrote: > ...
4 years, 3 months ago (2016-09-01 17:13:23 UTC) #5
siva
4 years, 3 months ago (2016-09-01 17:21:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
780ef512159d3f4e6c06fe51bed72eebe863a82e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698