Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: runtime/bin/BUILD.gn

Issue 2305483002: Add missing dependency in the rule which generates io_gen.cc (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 declare_args() { 6 declare_args() {
7 dart_io_support = false 7 dart_io_support = false
8 8
9 # TODO(zra, jamesr): Remove this check once we start building boringssl for 9 # TODO(zra, jamesr): Remove this check once we start building boringssl for
10 # the fuchsia port. 10 # the fuchsia port.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 template("gen_library_src_path") { 47 template("gen_library_src_path") {
48 assert(defined(invoker.sources), "Need sources in $target_name") 48 assert(defined(invoker.sources), "Need sources in $target_name")
49 assert(defined(invoker.output), "Need output in $target_name") 49 assert(defined(invoker.output), "Need output in $target_name")
50 action(target_name) { 50 action(target_name) {
51 visibility = [ ":*" ] # Only targets in this file can see this. 51 visibility = [ ":*" ] # Only targets in this file can see this.
52 script = "../tools/gen_library_src_paths.py" 52 script = "../tools/gen_library_src_paths.py"
53 inputs = [ 53 inputs = [
54 "../tools/gen_library_src_paths.py", 54 "../tools/gen_library_src_paths.py",
55 "builtin_in.cc", 55 "builtin_in.cc",
56 ] 56 ] + invoker.sources
jsimmons1 2016/09/01 00:08:34 Other actions in this file that pass a list of sou
siva 2016/09/01 17:13:23 I believe the rule for gen_resources_cc is ok as a
57 outputs = [ invoker.output, ] 57 outputs = [ invoker.output, ]
58 name = invoker.name 58 name = invoker.name
59 kind = invoker.kind 59 kind = invoker.kind
60 args = [ 60 args = [
61 "--output", rebase_path(invoker.output, root_build_dir), 61 "--output", rebase_path(invoker.output, root_build_dir),
62 "--input_cc", rebase_path("builtin_in.cc", root_build_dir), 62 "--input_cc", rebase_path("builtin_in.cc", root_build_dir),
63 "--include", "bin/builtin.h", 63 "--include", "bin/builtin.h",
64 "--var_name", "dart::bin::Builtin::${name}_${kind}_paths_", 64 "--var_name", "dart::bin::Builtin::${name}_${kind}_paths_",
65 "--library_name", "dart:${name}",] + 65 "--library_name", "dart:${name}",] +
66 rebase_path(invoker.sources, root_build_dir) 66 rebase_path(invoker.sources, root_build_dir)
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
566 sources = [ 566 sources = [
567 "run_vm_tests_fuchsia.cc" 567 "run_vm_tests_fuchsia.cc"
568 ] 568 ]
569 libs = [ 569 libs = [
570 "launchpad", 570 "launchpad",
571 "magenta", 571 "magenta",
572 "runtime", 572 "runtime",
573 ] 573 ]
574 } 574 }
575 } # defined(is_fuchsia) && is_fuchsia 575 } # defined(is_fuchsia) && is_fuchsia
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698