Enable angle_deqp_gles2_tests on Nexus 5X.

Enable angle_deqp_gles2_tests on Nexus 5X.

BUG=angleproject:1471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/198198900ec8d059d4d92be422cd65765c5a9ecf
Cr-Commit-Position: refs/heads/master@{#418393}

[ynovikov, 2016-09-01 21:45:47]

Description was changed from

==========
Enable angle_deqp_gles2_tests on Nexus 5X.

BUG=angleproject:1471
==========

to

==========
Enable angle_deqp_gles2_tests on Nexus 5X.

BUG=angleproject:1471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ynovikov, 2016-09-01 21:47:45]

ynovikov@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-09-01 21:48:36]

Very nice. LGTM

[ynovikov, 2016-09-01 22:08:18]

The CQ bit was checked by ynovikov@chromium.org

[ynovikov, 2016-09-01 22:08:19]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2305453004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-01 22:08:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ynovikov, 2016-09-01 22:24:42]

The CQ bit was unchecked by ynovikov@chromium.org

[ynovikov, 2016-09-01 23:05:03]

ynovikov@chromium.org changed reviewers:
+ dpranke@chromium.org

[Ken Russell (switch to Gerrit), 2016-09-01 23:13:21]

Still LGTM

[M-A Ruel, 2016-09-01 23:38:45]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2016-09-01 23:38:45]

lgtm

[Dirk Pranke, 2016-09-02 16:59:33]

https://codereview.chromium.org/2305453004/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2305453004/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1623: 'angle_deqp_tests',
The name of this config should change to make it clear that you're also adding
in the angle_deqp_tests flag. And, that flag should probably move earlier in the
list, to something like:

'swarming_android_gn_angle_deqp_tests_release_trybot_arm64': [
  'swarming', 'android', 'gn', 'angle_deqp_tests', 'release_trybot', 'arm64',
]

[ynovikov, 2016-09-08 23:20:39]

https://codereview.chromium.org/2305453004/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2305453004/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1623: 'angle_deqp_tests',
On 2016/09/02 16:59:33, Dirk Pranke wrote:
> The name of this config should change to make it clear that you're also adding
> in the angle_deqp_tests flag. And, that flag should probably move earlier in
the
> list, to something like:
> 
> 'swarming_android_gn_angle_deqp_tests_release_trybot_arm64': [
>   'swarming', 'android', 'gn', 'angle_deqp_tests', 'release_trybot', 'arm64',
> ]

Done.

[ynovikov, 2016-09-12 22:55:30]

On 2016/09/08 23:20:39, ynovikov wrote:
> https://codereview.chromium.org/2305453004/diff/40001/tools/mb/mb_config.pyl
> File tools/mb/mb_config.pyl (right):
> 
>
https://codereview.chromium.org/2305453004/diff/40001/tools/mb/mb_config.pyl#...
> tools/mb/mb_config.pyl:1623: 'angle_deqp_tests',
> On 2016/09/02 16:59:33, Dirk Pranke wrote:
> > The name of this config should change to make it clear that you're also
adding
> > in the angle_deqp_tests flag. And, that flag should probably move earlier in
> the
> > list, to something like:
> > 
> > 'swarming_android_gn_angle_deqp_tests_release_trybot_arm64': [
> >   'swarming', 'android', 'gn', 'angle_deqp_tests', 'release_trybot',
'arm64',
> > ]
> 
> Done.

ping

[ynovikov, 2016-09-13 01:51:05]

The CQ bit was checked by ynovikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 01:51:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 02:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 02:55:00]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-09-13 22:03:38]

lgtm

[Dirk Pranke, 2016-09-13 22:03:55]

Sorry for the delay, not sure why I didn't see the pings ...

[ynovikov, 2016-09-13 22:11:51]

On 2016/09/13 22:03:55, Dirk Pranke wrote:
> Sorry for the delay, not sure why I didn't see the pings ...

Thanks!

[ynovikov, 2016-09-13 22:11:56]

The CQ bit was checked by ynovikov@chromium.org

[ynovikov, 2016-09-13 22:11:57]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2305453004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-13 22:12:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:21:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-13 22:23:33]

Description was changed from

==========
Enable angle_deqp_gles2_tests on Nexus 5X.

BUG=angleproject:1471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable angle_deqp_gles2_tests on Nexus 5X.

BUG=angleproject:1471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/198198900ec8d059d4d92be422cd65765c5a9ecf
Cr-Commit-Position: refs/heads/master@{#418393}
==========

[commit-bot: I haz the power, 2016-09-13 22:23:34]

Patchset 5 (id:??) landed as
https://crrev.com/198198900ec8d059d4d92be422cd65765c5a9ecf
Cr-Commit-Position: refs/heads/master@{#418393}