YCM: Support Objective-C and Objective-C++

YCM: Support Objective-C and Objective-C++

BUG=643283
Committed: https://crrev.com/de05ce93179b3822dd50d34792d5cf9854f0ce67
Cr-Commit-Position: refs/heads/master@{#417733}

[Sidney San Martín, 2016-09-01 17:52:35]

sdy@chromium.org changed reviewers:
+ asanka@chromium.org

[asanka, 2016-09-01 20:37:19]

Would you mind adding a test for this?

[Sidney San Martín, 2016-09-01 22:21:30]

On 2016/09/01 20:37:19, asanka wrote:
> Would you mind adding a test for this?

Done!

[asanka, 2016-09-02 15:00:50]

LGTM with test fix.

https://codereview.chromium.org/2305443004/diff/40001/tools/vim/tests/chromiu...
File tools/vim/tests/chromium.ycm_extra_conf_unittest.py (right):

https://codereview.chromium.org/2305443004/diff/40001/tools/vim/tests/chromiu...
tools/vim/tests/chromium.ycm_extra_conf_unittest.py:238:
self.assertEqual(GetLastLangFlag(result['flags']), 'objective-c')
"-x objective-c" might not be the last flag since clang_flags comes after,
right?

You might just want to test that '-x objective-c' pair of flags are somewhere on
the command line.

E.g.: self.assertTrue(('-x', 'objective-c') in zip([''] + flags, flags))

or something more readable.

[Sidney San Martín, 2016-09-02 15:07:07]

https://codereview.chromium.org/2305443004/diff/40001/tools/vim/tests/chromiu...
File tools/vim/tests/chromium.ycm_extra_conf_unittest.py (right):

https://codereview.chromium.org/2305443004/diff/40001/tools/vim/tests/chromiu...
tools/vim/tests/chromium.ycm_extra_conf_unittest.py:238:
self.assertEqual(GetLastLangFlag(result['flags']), 'objective-c')
On 2016/09/02 15:00:50, asanka wrote:
> "-x objective-c" might not be the last flag since clang_flags comes after,
> right?
> 
> You might just want to test that '-x objective-c' pair of flags are somewhere
on
> the command line.
> 
> E.g.: self.assertTrue(('-x', 'objective-c') in zip([''] + flags, flags))
> 
> or something more readable.

It may not be the last flag, but it does need to be the last ('-x', 'lang')
pair. The default command line already includes ('-x', 'c++'), which is fine as
long as we have an ('-x', 'objective-c') later. I'm definitely open to more
readable versions, but I think they need to test that property.

[asanka, 2016-09-02 15:41:03]

On 2016/09/02 at 15:07:07, sdy wrote:
>
https://codereview.chromium.org/2305443004/diff/40001/tools/vim/tests/chromiu...
> File tools/vim/tests/chromium.ycm_extra_conf_unittest.py (right):
> 
>
https://codereview.chromium.org/2305443004/diff/40001/tools/vim/tests/chromiu...
> tools/vim/tests/chromium.ycm_extra_conf_unittest.py:238:
self.assertEqual(GetLastLangFlag(result['flags']), 'objective-c')
> On 2016/09/02 15:00:50, asanka wrote:
> > "-x objective-c" might not be the last flag since clang_flags comes after,
> > right?
> > 
> > You might just want to test that '-x objective-c' pair of flags are
somewhere on
> > the command line.
> > 
> > E.g.: self.assertTrue(('-x', 'objective-c') in zip([''] + flags, flags))
> > 
> > or something more readable.
> 
> It may not be the last flag, but it does need to be the last ('-x', 'lang')
pair. The default command line already includes ('-x', 'c++'), which is fine as
long as we have an ('-x', 'objective-c') later. I'm definitely open to more
readable versions, but I think they need to test that property.

Got it. LGTM

[Sidney San Martín, 2016-09-09 21:37:50]

The CQ bit was checked by sdy@chromium.org

[Sidney San Martín, 2016-09-09 21:37:51]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/2305443004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-09 21:38:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 22:19:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-09 22:20:47]

Description was changed from

==========
YCM: Support Objective-C and Objective-C++

BUG=643283
==========

to

==========
YCM: Support Objective-C and Objective-C++

BUG=643283

Committed: https://crrev.com/de05ce93179b3822dd50d34792d5cf9854f0ce67
Cr-Commit-Position: refs/heads/master@{#417733}
==========

[commit-bot: I haz the power, 2016-09-09 22:20:48]

Patchset 4 (id:??) landed as
https://crrev.com/de05ce93179b3822dd50d34792d5cf9854f0ce67
Cr-Commit-Position: refs/heads/master@{#417733}