YCM: Support Objective-C and Objective-C++

tools/vim/tests/chromium.ycm_extra_conf_unittest.py

 #!/usr/bin/env python
 
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Tests for chromium.ycm_extra_conf.
 
 These tests should be getting picked up by the PRESUBMIT.py in /tools/vim.
 Currently the tests only run on Linux and require 'ninja' to be available on
@@ skipping 35 matching lines @@
       with open(copy_from, 'r') as source:
         contents = source.read()
         if format_with:
           formatter = string.Formatter()
           contents = formatter.vformat(contents, None, format_with)
         f.write(contents)
   if make_executable:
     statinfo = os.stat(path)
     os.chmod(path, statinfo.st_mode | stat.S_IXUSR)
 
+def GetLastLangFlag(flags):
+  lastLang = None
+  for i, flag in enumerate(flags):
+      if flag =='-x':
+        lastLang = flags[i+1]
+  return lastLang
+
 class Chromium_ycmExtraConfTest(unittest.TestCase):
 
   def SetUpFakeChromeTreeBelowPath(self):
     """Create fake Chromium source tree under self.test_root.
 
     The fake source tree has the following contents:
 
     <self.test_root>
       |  .gclient
       |
@@ skipping 151 matching lines @@
         '-std=c++11',
         '-x', 'c++',
         '-I[SRC]',
         '-Wno-unknown-warning-option',
         '-I[OUT]/a',
         '-isysroot',
         '/mac.sdk',
         '-I[OUT]/tag-default'
         ])
 
+  def testGetFlagsForFileForUnknownObjcFile(self):
+    result = self.ycm_extra_conf.FlagsForFile(
+        os.path.join(self.chrome_root, 'nonexistent.m'))
+    self.assertTrue(result)
+    self.assertEqual(GetLastLangFlag(result['flags']), 'objective-c')

[asanka, 2016/09/02 15:00:50]

"-x objective-c" might not be the last flag since clang_flags comes after,
right?

You might just want to test that '-x objective-c' pair of flags are somewhere on
the command line.

E.g.: self.assertTrue(('-x', 'objective-c') in zip([''] + flags, flags))

or something more readable.

[Sidney San Martín, 2016/09/02 15:07:07]

It may not be the last flag, but it does need to be the last ('-x', 'lang')
pair. The default command line already includes ('-x', 'c++'), which is fine as
long as we have an ('-x', 'objective-c') later. I'm definitely open to more
readable versions, but I think they need to test that property.

+
+  def testGetFlagsForFileForUnknownObjcppFile(self):
+    result = self.ycm_extra_conf.FlagsForFile(
+        os.path.join(self.chrome_root, 'nonexistent.mm'))
+    self.assertTrue(result)
+    self.assertEqual(GetLastLangFlag(result['flags']), 'objective-c++')
+
   def testGetFlagsForFileForUnknownHeaderFile(self):
     result = self.ycm_extra_conf.FlagsForFile(
         os.path.join(self.chrome_root, 'nonexistent.h'))
     self.assertTrue(result)
     self.assertTrue('do_cache' in result)
     self.assertTrue(result['do_cache'])
     self.assertTrue('flags' in result)
     self.assertEquals(self.NormalizeStringsInList(result['flags']), [
         '-DUSE_CLANG_COMPLETER',
         '-std=c++11',
@@ skipping 147 matching lines @@
         '-Wno-unknown-warning-option',
         '-I[OUT]/a',
         '--sysroot=[SRC]/build/sysroot-image',
         ])
 
 if __name__ == '__main__':
   if not os.path.isfile('chromium.ycm_extra_conf.py'):
     print('The test must be run from src/tools/vim/ directory')
     sys.exit(1)
   unittest.main()