GN(Android): Stop specifying depfile under outputs

GN(Android): Stop specifying depfile under outputs

Doing so is unnecessary (GN already knows that depfiles are generated by
their target), and causes the unwanted side-effect of changes to .d
files triggering rebuilds of dependent targets.

BUG=639042
Committed: https://crrev.com/fd47b4e4232b99dfb4044b79eea66a7e6b2c2a64
Cr-Commit-Position: refs/heads/master@{#416710}

[agrieve, 2016-09-05 00:50:32]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org, michaelbai@chromium.org

[agrieve, 2016-09-05 00:50:32]

michaelbai for android_webview

dpranke for overall change.

[Dirk Pranke, 2016-09-06 01:28:54]

lgtm, except for the one re-use of depfile that I think we should change if
possible (commented below).

https://codereview.chromium.org/2305283002/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2305283002/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:391: depfile,  # Doubles as a stamp
file.
This just seems like a bad idea, even if it's theoretically safe (because it'll
lead to confusion). 

Can we create a separate stamp file?

[michaelbai, 2016-09-06 16:47:46]

Is android_webview change related to depfile? or it is a clean up.

[agrieve, 2016-09-06 16:51:35]

On 2016/09/06 16:47:46, michaelbai wrote:
> Is android_webview change related to depfile? or it is a clean up.

It's related to depfile. It used to use get_target_outputs()[1], but with
depfile removed, it should be get_target_outputs()[0]. Instead though, I just
used a variable (so that it's no longer dependent on the output ordering).

[michaelbai, 2016-09-06 17:49:29]

Thanks LGTM

[agrieve, 2016-09-06 18:51:47]

https://codereview.chromium.org/2305283002/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2305283002/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:391: depfile,  # Doubles as a stamp
file.
On 2016/09/06 01:28:53, Dirk Pranke wrote:
> This just seems like a bad idea, even if it's theoretically safe (because
it'll
> lead to confusion). 
> 
> Can we create a separate stamp file?

Agreed. Fixed.

[agrieve, 2016-09-06 18:51:52]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:52:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 20:11:30]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-09-06 20:29:47]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-09-06 20:29:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelbai@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2305283002/#ps20001
(title: "add stamp file to copy_ex")

[commit-bot: I haz the power, 2016-09-06 20:30:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:38:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 20:41:21]

Description was changed from

==========
GN(Android): Stop specifying depfile under outputs

Doing so is unnecessary (GN already knows that depfiles are generated by
their target), and causes the unwanted side-effect of changes to .d
files triggering rebuilds of dependent targets.

BUG=639042
==========

to

==========
GN(Android): Stop specifying depfile under outputs

Doing so is unnecessary (GN already knows that depfiles are generated by
their target), and causes the unwanted side-effect of changes to .d
files triggering rebuilds of dependent targets.

BUG=639042

Committed: https://crrev.com/fd47b4e4232b99dfb4044b79eea66a7e6b2c2a64
Cr-Commit-Position: refs/heads/master@{#416710}
==========

[commit-bot: I haz the power, 2016-09-06 20:41:22]

Patchset 2 (id:??) landed as
https://crrev.com/fd47b4e4232b99dfb4044b79eea66a7e6b2c2a64
Cr-Commit-Position: refs/heads/master@{#416710}

[Dirk Pranke, 2016-09-06 21:05:05]

lgtm

[lushnikov, 2016-09-06 21:59:34]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2318673003/ by lushnikov@chromium.org.

The reason for reverting is: Reverting due to builder compile failure:
https://build.chromium.org/p/chromium/builders/Android/builds/61823.

[agrieve, 2016-09-07 02:25:58]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2315993002/ by agrieve@chromium.org.

The reason for reverting is: Will update when fixed..

[agrieve, 2016-09-07 02:27:31]

On 2016/09/07 02:25:58, agrieve wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2315993002/ by mailto:agrieve@chromium.org.
> 
> The reason for reverting is: Will update when fixed..

Whoops, meant to create a reland, not another revert :P. Please disregard.