Clean up and fix logic around creating ImageBufferSurface and fallbacks

Clean up and fix logic around creating ImageBufferSurface and fallbacks

Avoids a crash if a surface is not valid, we always early out in that
case. Repairs the fallback logic to not fallback in the cases where:
- An external surface was provided.
- is3D() is true, aka WebGL.
In the above cases, we should not fallback if the surface we try to use
is not valid.

TBR=junov@chromium.org
BUG=641896
Review-Url: https://codereview.chromium.org/2285153004
Cr-Commit-Position: refs/heads/master@{#416097}
(cherry picked from commit 3c5a6056fca4642b919fb468c6ca9bfc152d1c76)

Committed: https://chromium.googlesource.com/chromium/src/+/1b2b61b508e917e4e34c1c1a629efcf1c8d7197e

[danakj, 2016-09-03 00:59:05]

Description was changed from

==========
Clean up and fix logic around creating ImageBufferSurface and fallbacks

Avoids a crash if a surface is not valid, we always early out in that
case. Repairs the fallback logic to not fallback in the cases where:
- An external surface was provided.
- is3D() is true, aka WebGL.
In the above cases, we should not fallback if the surface we try to use
is not valid.

TBR=junov@chromium.org
BUG=641896

Review-Url: https://codereview.chromium.org/2285153004
Cr-Commit-Position: refs/heads/master@{#416097}
(cherry picked from commit 3c5a6056fca4642b919fb468c6ca9bfc152d1c76)
==========

to

==========
Clean up and fix logic around creating ImageBufferSurface and fallbacks

Avoids a crash if a surface is not valid, we always early out in that
case. Repairs the fallback logic to not fallback in the cases where:
- An external surface was provided.
- is3D() is true, aka WebGL.
In the above cases, we should not fallback if the surface we try to use
is not valid.

TBR=junov@chromium.org
BUG=641896

Review-Url: https://codereview.chromium.org/2285153004
Cr-Commit-Position: refs/heads/master@{#416097}
(cherry picked from commit 3c5a6056fca4642b919fb468c6ca9bfc152d1c76)

Committed:
https://chromium.googlesource.com/chromium/src/+/1b2b61b508e917e4e34c1c1a629e...
==========

[danakj, 2016-09-03 00:59:06]

Committed patchset #1 (id:1) manually as
1b2b61b508e917e4e34c1c1a629efcf1c8d7197e.

[Justin Novosad, 2016-09-06 21:25:32]

lgtm