Clean up and fix logic around creating ImageBufferSurface and fallbacks

Clean up and fix logic around creating ImageBufferSurface and fallbacks

Avoids a crash if a surface is not valid, we always early out in that
case. Repairs the fallback logic to not fallback in the cases where:
- An external surface was provided.
- is3D() is true, aka WebGL.
In the above cases, we should not fallback if the surface we try to use
is not valid.

R=junov@chromium.org
BUG=641896
Committed: https://crrev.com/3c5a6056fca4642b919fb468c6ca9bfc152d1c76
Cr-Commit-Position: refs/heads/master@{#416097}

[danakj, 2016-08-30 01:39:55]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-08-30 02:28:34]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 02:45:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-08-30 02:48:59]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 03:45:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 05:38:08]

Dry run: This issue passed the CQ dry run.

[Justin Novosad, 2016-08-30 15:38:51]

On 2016/08/30 01:39:48, danakj wrote:

lgtm

[danakj, 2016-09-01 19:10:25]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-09-01 19:10:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:46:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 22:48:41]

Description was changed from

==========
Clean up and fix logic around creating ImageBufferSurface and fallbacks

Avoids a crash if a surface is not valid, we always early out in that
case. Repairs the fallback logic to not fallback in the cases where:
- An external surface was provided.
- is3D() is true, aka WebGL.
In the above cases, we should not fallback if the surface we try to use
is not valid.

R=junov@chromium.org
BUG=641896
==========

to

==========
Clean up and fix logic around creating ImageBufferSurface and fallbacks

Avoids a crash if a surface is not valid, we always early out in that
case. Repairs the fallback logic to not fallback in the cases where:
- An external surface was provided.
- is3D() is true, aka WebGL.
In the above cases, we should not fallback if the surface we try to use
is not valid.

R=junov@chromium.org
BUG=641896

Committed: https://crrev.com/3c5a6056fca4642b919fb468c6ca9bfc152d1c76
Cr-Commit-Position: refs/heads/master@{#416097}
==========

[commit-bot: I haz the power, 2016-09-01 22:48:42]

Patchset 2 (id:??) landed as
https://crrev.com/3c5a6056fca4642b919fb468c6ca9bfc152d1c76
Cr-Commit-Position: refs/heads/master@{#416097}