Fix NOTREACHED() in abortIfUpdating() when aborting 0-byte appendBuffer

Fix NOTREACHED() in abortIfUpdating() when aborting 0-byte appendBuffer

BUG=643788
TEST=upstream w3c web-platform-tests/media-source/mediasource-removesourcebuffer.html

Committed: https://crrev.com/016559ca79587b9ec5b4e8fda0117b12cb42f738
Cr-Commit-Position: refs/heads/master@{#416357}

[wolenetz, 2016-09-02 20:08:58]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 20:09:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wolenetz, 2016-09-02 20:10:52]

wolenetz@chromium.org changed reviewers:
+ chcunningham@chromium.org

[wolenetz, 2016-09-02 20:10:53]

Please take a look. I can show you local results of this patch against that
upstream w-p-t test.

https://codereview.chromium.org/2305023002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp (left):

https://codereview.chromium.org/2305023002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp:485: if
(!m_pendingAppendData.isEmpty()) {
It's entirely possible for pendingAppendData to be empty when aborting an
asynchronous 0-byte appendBuffer. This CL avoids the NOTREACHED() on debug
builds, and uses the correct traceEventName in all build types.

[chcunningham, 2016-09-02 20:48:39]

lgtm

[wolenetz, 2016-09-02 20:51:46]

thanks for the review.

[wolenetz, 2016-09-02 20:51:53]

The CQ bit was unchecked by wolenetz@chromium.org

[wolenetz, 2016-09-02 20:51:57]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:52:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:58:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 22:01:07]

Description was changed from

==========
Fix NOTREACHED() in abortIfUpdating() when aborting 0-byte appendBuffer

BUG=643788
TEST=upstream w3c
web-platform-tests/media-source/mediasource-removesourcebuffer.html
==========

to

==========
Fix NOTREACHED() in abortIfUpdating() when aborting 0-byte appendBuffer

BUG=643788
TEST=upstream w3c
web-platform-tests/media-source/mediasource-removesourcebuffer.html

Committed: https://crrev.com/016559ca79587b9ec5b4e8fda0117b12cb42f738
Cr-Commit-Position: refs/heads/master@{#416357}
==========

[commit-bot: I haz the power, 2016-09-02 22:01:08]

Patchset 1 (id:??) landed as
https://crrev.com/016559ca79587b9ec5b4e8fda0117b12cb42f738
Cr-Commit-Position: refs/heads/master@{#416357}