Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

Issue 2305023002: Fix NOTREACHED() in abortIfUpdating() when aborting 0-byte appendBuffer (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
index 58c74056c0aa95cff1584e1451963747d47ff7f4..1e3286b94922987c3fcb4f253a1d4816d78683e2 100644
--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
@@ -482,12 +482,10 @@ void SourceBuffer::abortIfUpdating()
DCHECK_EQ(m_pendingRemoveStart, -1);
const char* traceEventName = 0;
- if (!m_pendingAppendData.isEmpty()) {
wolenetz 2016/09/02 20:10:53 It's entirely possible for pendingAppendData to be
- traceEventName = "SourceBuffer::appendBuffer";
- } else if (m_stream) {
+ if (m_stream) {
traceEventName = "SourceBuffer::appendStream";
} else {
- NOTREACHED();
+ traceEventName = "SourceBuffer::appendBuffer";
}
// 4.1. Abort the buffer append and stream append loop algorithms if they are running.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698