Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

Issue 2305013002: Adding parse UMA and pingback metrics (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
index dd64de21114a52e7d29c8a5848117322eeeeeebd..ed6c2271c515a0397916a69d1f3ff5727a9288dd 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
@@ -59,20 +59,31 @@ void AddDataToPageloadMetrics(const DataReductionProxyData& request_data,
protobuf_parser::CreateDurationFromTimeDelta(
timing.response_start.value())
.release());
}
if (timing.load_event_start) {
request->set_allocated_page_load_time(
protobuf_parser::CreateDurationFromTimeDelta(
timing.load_event_start.value())
.release());
}
+ if (timing.parse_blocked_on_script_load_duration) {
+ request->set_allocated_parse_blocked_on_script_load_duration(
+ protobuf_parser::CreateDurationFromTimeDelta(
+ timing.parse_blocked_on_script_load_duration.value())
+ .release());
+ }
+ if (timing.parse_stop) {
+ request->set_allocated_parse_stop(
+ protobuf_parser::CreateDurationFromTimeDelta(timing.parse_stop.value())
+ .release());
+ }
request->set_effective_connection_type(
protobuf_parser::ProtoEffectiveConnectionTypeFromEffectiveConnectionType(
request_data.effective_connection_type()));
}
// Adds |current_time| as the metrics sent time to |request_data|, and returns
// the serialized request.
std::string AddTimeAndSerializeRequest(
RecordPageloadMetricsRequest* request_data,

Powered by Google App Engine
This is Rietveld 408576698