Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4990)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Issue 2305013002: Adding parse UMA and pingback metrics (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
index ab6c9ddf463f242d3582aecb5bd1fdd088f2253e..c1450227c741c0390498a9c83016db06cf5ca89d 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -131,20 +131,23 @@ class DataReductionProxyMetricsObserverTest
void ResetTest() {
// Reset to the default testing state. Does not reset histogram state.
timing_.navigation_start = base::Time::FromDoubleT(1);
timing_.response_start = base::TimeDelta::FromSeconds(2);
timing_.parse_start = base::TimeDelta::FromSeconds(3);
timing_.first_contentful_paint = base::TimeDelta::FromSeconds(4);
timing_.first_image_paint = base::TimeDelta::FromSeconds(5);
timing_.first_text_paint = base::TimeDelta::FromSeconds(6);
timing_.load_event_start = base::TimeDelta::FromSeconds(7);
+ timing_.parse_stop = base::TimeDelta::FromSeconds(4);
+ timing_.parse_blocked_on_script_load_duration =
+ base::TimeDelta::FromSeconds(1);
PopulateRequiredTimingFields(&timing_);
}
void RunTest(bool data_reduction_proxy_used, bool is_using_lofi) {
data_reduction_proxy_used_ = data_reduction_proxy_used;
is_using_lofi_ = is_using_lofi;
NavigateAndCommit(GURL(kDefaultTestUrl));
SimulateTimingUpdate(timing_);
pingback_client_->Reset();
@@ -190,20 +193,26 @@ class DataReductionProxyMetricsObserverTest
ValidateHistogramsForSuffix(internal::kHistogramFirstContentfulPaintSuffix,
timing_.first_contentful_paint);
ValidateHistogramsForSuffix(internal::kHistogramFirstImagePaintSuffix,
timing_.first_image_paint);
ValidateHistogramsForSuffix(internal::kHistogramFirstPaintSuffix,
timing_.first_paint);
ValidateHistogramsForSuffix(internal::kHistogramFirstTextPaintSuffix,
timing_.first_text_paint);
ValidateHistogramsForSuffix(internal::kHistogramParseStartSuffix,
timing_.parse_start);
+ ValidateHistogramsForSuffix(
+ internal::kHistogramParseBlockedOnScriptLoadSuffix,
+ timing_.parse_blocked_on_script_load_duration);
+ ValidateHistogramsForSuffix(
+ internal::kHistogramParseDurationSuffix,
+ timing_.parse_stop.value() - timing_.parse_start.value());
}
void ValidateHistogramsForSuffix(
const std::string& histogram_suffix,
const base::Optional<base::TimeDelta>& event) {
histogram_tester().ExpectTotalCount(
std::string(internal::kHistogramDataReductionProxyPrefix)
.append(histogram_suffix),
data_reduction_proxy_used_ ? 1 : 0);
histogram_tester().ExpectTotalCount(

Powered by Google App Engine
This is Rietveld 408576698