Fix NGBox's iterator logic

Fix NGBox's iterator logic: FirstChild/NextSibling should return cached values instead of generating new one every time they are called.

BUG=635619
Committed: https://crrev.com/cc5ee3bd153773ff5e1b5b2ffcb4a392036d5c3d
Cr-Commit-Position: refs/heads/master@{#416355}

[Gleb Lanbin, 2016-09-02 19:10:59]

Description was changed from

==========
Fix NGBox iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619
==========

to

==========
Fix NGBox iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619
==========

[Gleb Lanbin, 2016-09-02 19:11:12]

Description was changed from

==========
Fix NGBox iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619
==========

to

==========
Fix NGBox's iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619
==========

[Gleb Lanbin, 2016-09-02 19:11:35]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2016-09-02 19:12:23]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2016-09-02 19:17:47]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 19:18:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-09-02 20:58:47]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org

[ikilpatrick, 2016-09-02 20:58:48]

lgtm

https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:113: String
toString() const;
ToString now i think?

[commit-bot: I haz the power, 2016-09-02 21:19:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 21:19:02]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2016-09-02 21:48:57]

thanks for the review.

https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:113: String
toString() const;
On 2016/09/02 20:58:48, ikilpatrick wrote:
> ToString now i think?

no, it's toString
https://cs.chromium.org/search/?q=case:yes+toString+file:%5Esrc/third_party/W....

[Gleb Lanbin, 2016-09-02 21:50:03]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2016-09-02 21:50:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:55:42]

Description was changed from

==========
Fix NGBox's iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619
==========

to

==========
Fix NGBox's iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619
==========

[commit-bot: I haz the power, 2016-09-02 21:55:43]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-02 21:58:37]

Description was changed from

==========
Fix NGBox's iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619
==========

to

==========
Fix NGBox's iterator logic: FirstChild/NextSibling should return cached values
instead of generating new one every time they are called.

BUG=635619

Committed: https://crrev.com/cc5ee3bd153773ff5e1b5b2ffcb4a392036d5c3d
Cr-Commit-Position: refs/heads/master@{#416355}
==========

[commit-bot: I haz the power, 2016-09-02 21:58:38]

Patchset 1 (id:??) landed as
https://crrev.com/cc5ee3bd153773ff5e1b5b2ffcb4a392036d5c3d
Cr-Commit-Position: refs/heads/master@{#416355}

[cbiesinger1, 2016-09-02 22:00:11]

cbiesinger@google.com changed reviewers:
+ cbiesinger@google.com

[cbiesinger1, 2016-09-02 22:00:11]

Lgtm

https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:113: String
toString() const;
On 2016/09/02 21:48:57, glebl wrote:
> On 2016/09/02 20:58:48, ikilpatrick wrote:
> > ToString now i think?
> 
> no, it's toString
>
https://cs.chromium.org/search/?q=case:yes+toString+file:%5Esrc/third_party/W....

But we're using Chromium style now, is it still lowercase?

[Gleb Lanbin, 2016-09-06 21:45:42]

On 2016/09/02 22:00:11, cbiesinger1 wrote:
> Lgtm
> 
>
https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):
> 
>
https://codereview.chromium.org/2304993002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:113: String
> toString() const;
> On 2016/09/02 21:48:57, glebl wrote:
> > On 2016/09/02 20:58:48, ikilpatrick wrote:
> > > ToString now i think?
> > 
> > no, it's toString
> >
>
https://cs.chromium.org/search/?q=case:yes+toString+file:%5Esrc/third_party/W....
> 
> But we're using Chromium style now, is it still lowercase?

you're right. it should be ToString. I will change it in the next patch.

[eae, 2016-09-06 21:51:47]

LGTM (post facto)