Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2304993002: Fix NGBox's iterator logic (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
index 04c25f3a94c5020bb0bc3d5348f7846c7cf7e185..cb266a7aca30c581c813bed9669567ac104ffe9f 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
@@ -10,6 +10,7 @@
#include "core/layout/ng/ng_physical_constraint_space.h"
#include "core/layout/ng/ng_writing_mode.h"
#include "platform/heap/Handle.h"
+#include "wtf/text/WTFString.h"
namespace blink {
@@ -61,7 +62,7 @@ class CORE_EXPORT NGConstraintSpace final
// Size of the container. Used for the following three cases:
// 1) Percentage resolution.
// 2) Resolving absolute positions of children.
- // 3) Defining the threashold that triggers the presence of a scrollbar. Only
+ // 3) Defining the threshold that triggers the presence of a scrollbar. Only
// applies if the corresponding scrollbarTrigger flag has been set for the
// direction.
NGLogicalSize ContainerSize() const;
@@ -109,6 +110,8 @@ class CORE_EXPORT NGConstraintSpace final
void SetFixedSize(bool inlineFixed, bool blockFixed);
void SetFragmentationType(NGFragmentationType);
+ String toString() const;
ikilpatrick 2016/09/02 20:58:48 ToString now i think?
Gleb Lanbin 2016/09/02 21:48:57 no, it's toString https://cs.chromium.org/search/?
cbiesinger1 2016/09/02 22:00:11 But we're using Chromium style now, is it still lo
+
private:
Member<NGPhysicalConstraintSpace> physical_space_;
NGLogicalOffset offset_;
@@ -134,6 +137,11 @@ class CORE_EXPORT NGLayoutOpportunityIterator final {
bool for_inline_or_bfc_;
};
+inline std::ostream& operator<<(std::ostream& stream,
+ const NGConstraintSpace& value) {
+ return stream << value.toString();
+}
+
} // namespace blink
#endif // NGConstraintSpace_h
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_box.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698