[Android]Fix a regression that snackbar sits behind the scrim

[Android]Fix a regression that snackbar sits behind the scrim

After snackbar is held inside of the CompositorViewHolder, there is a
regression that the search suggestion scrim will hide the snackbar. This
CL fixes this regression by putting the search result container to be a
child of the CompositorViewHolder.

BUG=638506
Committed: https://crrev.com/d81a84024f39662df596f2dd99c34360e5bf7ae7
Cr-Commit-Position: refs/heads/master@{#416759}

[Ian Wen, 2016-09-02 18:50:26]

ianwen@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ian Wen, 2016-09-02 18:50:27]

PTAL :)

[Ian Wen, 2016-09-02 22:41:15]

In the second patchset I unified the behavior for both snackbars and suggestion
container. PTAL

[Ted C, 2016-09-02 23:23:16]

lgtm

https://codereview.chromium.org/2304943003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderBehavior.java
(right):

https://codereview.chromium.org/2304943003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderBehavior.java:53:
return ev.getX() > view.getX() && ev.getX() - view.getX() < view.getWidth()
should it be >= <=?

[Ian Wen, 2016-09-02 23:42:41]

On 2016/09/02 23:23:16, Ted C wrote:
> lgtm
> 
>
https://codereview.chromium.org/2304943003/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderBehavior.java
> (right):
> 
>
https://codereview.chromium.org/2304943003/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderBehavior.java:53:
> return ev.getX() > view.getX() && ev.getX() - view.getX() < view.getWidth()
> should it be >= <=?

Done.

[Ian Wen, 2016-09-02 23:42:56]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 23:43:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 01:28:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 01:28:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2016-09-06 21:40:38]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-09-06 21:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2304943003/#ps60001
(title: "add proguard config")

[commit-bot: I haz the power, 2016-09-06 21:41:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 23:14:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-06 23:17:25]

Description was changed from

==========
[Android]Fix a regression that snackbar sits behind the scrim

After snackbar is held inside of the CompositorViewHolder, there is a
regression that the search suggestion scrim will hide the snackbar. This
CL fixes this regression by putting the search result container to be a
child of the CompositorViewHolder.

BUG=638506
==========

to

==========
[Android]Fix a regression that snackbar sits behind the scrim

After snackbar is held inside of the CompositorViewHolder, there is a
regression that the search suggestion scrim will hide the snackbar. This
CL fixes this regression by putting the search result container to be a
child of the CompositorViewHolder.

BUG=638506

Committed: https://crrev.com/d81a84024f39662df596f2dd99c34360e5bf7ae7
Cr-Commit-Position: refs/heads/master@{#416759}
==========

[commit-bot: I haz the power, 2016-09-06 23:17:25]

Patchset 4 (id:??) landed as
https://crrev.com/d81a84024f39662df596f2dd99c34360e5bf7ae7
Cr-Commit-Position: refs/heads/master@{#416759}